Repository navigation
netutil: preserve UDP peer address after packet release - #36
Merged
Rememorio merged 1 commit intoAug 19, 2026
Merged
Conversation
Copy the IPv4 and IPv6 address bytes before returning a UDP peer address so receive-buffer reuse cannot mutate it. Add regression coverage for both address families.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
recheck |
1 similar comment
Contributor
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
SockaddrSliceToUDPAddrcurrently returns anet.IPslice that aliases the raw sockaddr memory in the UDP receive buffer.After
Packet.Free()orReadFromreturns, that buffer may be reused by a later receive operation. The peer IP retained by the caller can then be overwritten while the port remains unchanged, causing responses to be lost or sent to the wrong peer.Changes
net.UDPAddr.Compatibility
Validation
go test -race -count=10 ./internal/netutilgo test ./...go vet ./...