Skip to content

spring-boot-starter: fix configuration binding with Jackson 2.21 #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wardseptember merged 2 commits into from
Oct 19, 2026
Merged

spring-boot-starter: fix configuration binding with Jackson 2.21 #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b02714
spring-boot-starter: fix configuration binding with Jackson 2.21
JingkaiTang Oct 13, 2026
3d0198c
spring: update schema test to supported Jackson naming strategy
JingkaiTang Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ent/trpc/spring/boot/starters/context/configuration/bind/TRpcConfigurationBindResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import com.fasterxml.jackson.core.type.TypeReference;
import com.fasterxml.jackson.databind.DeserializationFeature;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.PropertyNamingStrategy;
import com.fasterxml.jackson.databind.PropertyNamingStrategies;
import com.tencent.trpc.core.logger.Logger;
import com.tencent.trpc.core.logger.LoggerFactory;
import com.tencent.trpc.core.utils.JsonUtils;
Expand All @@ -26,7 +26,7 @@ public class TRpcConfigurationBindResult {

private static final ObjectMapper MAP_CONVERTER = JsonUtils.copy()
.disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES)
.setPropertyNamingStrategy(PropertyNamingStrategy.SNAKE_CASE);
.setPropertyNamingStrategy(PropertyNamingStrategies.SNAKE_CASE);

private static final TypeReference<Map<String, Object>> MAP_TYPE = new TypeReference<Map<String, Object>>() {
};
Expand Down
65 changes: 65 additions & 0 deletions ...trpc/spring/boot/starters/context/configuration/bind/TRpcConfigurationBindResultTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
/*
* Tencent is pleased to support the open source community by making tRPC available.
*
* Copyright (C) 2026 THL A29 Limited, a Tencent company.
* All rights reserved.
*
* If you have downloaded a copy of the tRPC source code from Tencent,
* please note that tRPC source code is licensed under the Apache 2.0 License,
* A copy of the Apache 2.0 License can be found in the LICENSE file.
*/

package com.tencent.trpc.spring.boot.starters.context.configuration.bind;

import com.tencent.trpc.spring.boot.starters.context.configuration.TRpcConfigurationProperties;
import java.util.List;
import java.util.Map;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;

class TRpcConfigurationBindResultTest {

@Test
void toMapPreservesSnakeCaseConfiguration() {
TRpcConfigurationProperties properties = new TRpcConfigurationProperties();
properties.getGlobal().setEnvName("test-env");
properties.getGlobal().setFullSetName("app.area.unit");
properties.getServer().setLocalIp("127.0.0.1");
properties.getServer().setRequestTimeout(1234);
properties.getServer().setEnableLinkTimeout(false);
properties.getServer().setRunListeners(List.of("test-listener"));
properties.getClient().setRequestTimeout(2345);
properties.getClient().setCallerServiceName("test-caller");

Map<String, Object> result = new TRpcConfigurationBindResult(properties).toMap();

Map<?, ?> global = (Map<?, ?>) result.get("global");
Assertions.assertNotNull(global);
Assertions.assertEquals("test-env", global.get("env_name"));
Assertions.assertEquals("app.area.unit", global.get("full_set_name"));
Assertions.assertFalse(global.containsKey("envName"));
Map<?, ?> server = (Map<?, ?>) result.get("server");
Assertions.assertNotNull(server);
Assertions.assertEquals("127.0.0.1", server.get("local_ip"));
Assertions.assertEquals(1234, server.get("request_timeout"));
Assertions.assertEquals(false, server.get("enable_link_timeout"));
Assertions.assertEquals(List.of("test-listener"), server.get("run_listeners"));
Map<?, ?> client = (Map<?, ?>) result.get("client");
Assertions.assertNotNull(client);
Assertions.assertEquals(2345, client.get("request_timeout"));
Assertions.assertEquals("test-caller", client.get("caller_service_name"));
}

@Test
void toMapPreservesExtensionMapKeys() {
TRpcConfigurationProperties properties = new TRpcConfigurationProperties();
Map<String, Object> extension = Map.of("customKey", "value", "nested", Map.of("userKey", 17));
properties.getGlobal().setExt(extension);

Map<String, Object> result = new TRpcConfigurationBindResult(properties).toMap();

Map<?, ?> global = (Map<?, ?>) result.get("global");
Assertions.assertNotNull(global);
Assertions.assertEquals(extension, global.get("ext"));
}
}
4 changes: 2 additions & 2 deletions ...spring/src/test/java/com/tencent/trpc/spring/context/configuration/schema/SchemaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import com.fasterxml.jackson.core.type.TypeReference;
import com.fasterxml.jackson.databind.DeserializationFeature;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.PropertyNamingStrategy;
import com.fasterxml.jackson.databind.PropertyNamingStrategies;
import com.google.common.collect.Lists;
import com.tencent.trpc.core.utils.JsonUtils;
import com.tencent.trpc.spring.context.configuration.schema.client.ClientSchema;
Expand All @@ -38,7 +38,7 @@ public class SchemaTest {

private static final ObjectMapper MAP_CONVERTER = JsonUtils.copy()
.disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES)
.setPropertyNamingStrategy(PropertyNamingStrategy.SNAKE_CASE);
.setPropertyNamingStrategy(PropertyNamingStrategies.SNAKE_CASE);

private static final TypeReference<Map<String, Object>> MAP_TYPE =
new TypeReference<Map<String, Object>>() {
Expand Down
Loading