Repository navigation
trunk-merge/pr-1287/cbdbe1d6-87b7-42bb-85ef-143c5accebae - #1289
Closed
trunk-io[bot] wants to merge 5 commits into
Closed
trunk-io[bot] wants to merge 5 commits into
trunk-io[bot] wants to merge 5 commits into
Conversation
A run without --test-collection-id now asks the decision route too, by its repository. When trunk1 answers v2 with a testCollectionShortId, the run uses that collection for the v2 quarantine lookup and upload, as if it had been passed, and warns that 1.0.0 requires the id. A v2 answer with no collection falls back to v1. A run that names its collection ignores any inferred one. The test-runner plugins keep the inferred collection in their API version cache, so every worker process uses it, and print the warning on stderr. Deprecation notices now show in the upload's text output, since the console shows tracing only when verbose. Part of TRUNK-23145 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When getUploadApiVersion answers missingTestCollection, the run named no collection and Trunk could not infer one for a fully migrated org, so ingestion would drop a v1 upload. The CLI and the test-runner plugins now skip the upload and its telemetry and warn, with an UPLOAD_SKIPPED notice in the summary. The quarantine lookup is unchanged. Part of TRUNK-23145 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
UploadApiDecision::from_response holds the rules: a run that named its collection takes the answer's version as it is, and only a run that named none reads testCollectionShortId (with v2) or missingTestCollection (with v1). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With missingTestCollection the CLI now skips the quarantine lookup as well as the upload, and the test-runner plugins report a test as not quarantined without a lookup. v1 answers that lookup for a fully migrated org with 404 "A test collection is required", which quarantined nothing, so the exit code is the same as before. Part of TRUNK-23145 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1289 +/- ##
==========================================
- Coverage 85.45% 82.71% -2.75%
==========================================
Files 86 86
Lines 19259 19278 +19
==========================================
- Hits 16458 15945 -513
- Misses 2801 3333 +532 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
trunk-io
Bot
deleted the
trunk-merge/pr-1287/cbdbe1d6-87b7-42bb-85ef-143c5accebae
branch
November 4, 2026 19:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created and is being managed by Trunk Merge.
This pull request is based on the main branch at SHA 09ad25cc4cdc1a760bb0af41e9c35dc2bf9b4f9b.
See more details here.
When CI completes, this pull request will be closed automatically.
Pull Requests Being Tested
This pull request is testing the changes from pull request 1287.