Repository navigation
trunk-merge/pr-1277/a69f58bc-9e84-4ee0-a1a2-1c7876d1afb4 - #1290
Closed
trunk-io[bot] wants to merge 9 commits into
Closed
trunk-io[bot] wants to merge 9 commits into
trunk-io[bot] wants to merge 9 commits into
Conversation
Leaves stdout free for the command's own output, which the upcoming `--output-format json` relies on. Logs only show with `--verbose`, so default output is unchanged. TRUNK-22400 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`to_trace_filter` mapped `LevelFilter::Off` to `TRACE`, so the quietest setting logged the most. Map it to `LevelFilter::OFF` and filter events by level in the console layer. TRUNK-22400 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
As `tracing::error!`, each deprecation counted as an error in Sentry even though nothing failed. Log them with `warn!` and tag them with a `deprecated_flag` field. Sentry now records warnings with that field as warning-level events, with the same tags as errors, so we can still see which customers use deprecated flags. Other warnings stay breadcrumbs. This also starts reporting `--use-quarantining`, which was already a `warn!` and so never reached Sentry. TRUNK-22400 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
TRUNK-22400 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`run_test` didn't pass its `render_sender` to `run_upload`, so `test` skipped the slow-request messages that `upload` shows. TRUNK-22400 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
run() returns a Report, and main sends each part of it to its own stream: the summary goes to stdout with superconsole's emit_aux, while notices (deprecation warnings, BEP parse errors), the error of a run that fails outright, the test command header and the summary file message go to stderr. DisplayMessage::Final and the EndOutput trait are replaced by Report and Notice variants that carry the rendered lines. Scripts that capture only stderr will lose the summary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
main's #1287 printed Deprecation and UploadSkipped notices inside the upload summary. This branch already prints every notice on stderr through render_notices, so render UploadSkipped there and drop the copy in the summary, which would have printed each notice twice. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`--output-format json` (or `TRUNK_OUTPUT_FORMAT=json`) prints the summary on stdout as the same JSON that `--summary-output-file` writes, instead of the text summary. Logs, notices and progress stay on stderr, and a run that fails outright prints its JSON error object on stdout. Exit codes don't change. The flag lives in its own args struct used only by `upload` and `validate`: `test` includes `UploadArgs`, and its test command writes to stdout. The summary schema now covers the validate report (`"type": "VALIDATE"`). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1290 +/- ##
==========================================
+ Coverage 85.54% 86.02% +0.48%
==========================================
Files 86 85 -1
Lines 19405 19395 -10
==========================================
+ Hits 16600 16685 +85
+ Misses 2805 2710 -95 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
trunk-io
Bot
deleted the
trunk-merge/pr-1277/a69f58bc-9e84-4ee0-a1a2-1c7876d1afb4
branch
November 4, 2026 20:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created and is being managed by Trunk Merge.
This pull request is based on the main branch at SHA 03962cd17da8cc06eea4fda0da9d74e32bdcbe4d.
See more details here.
When CI completes, this pull request will be closed automatically.
Pull Requests Being Tested
This pull request is testing the changes from pull request 1277, stacked on pull requests 1266 and 1273.