Repository navigation
trunk-merge/pr-1281/e6868de7-3098-4b32-ba22-a36d514361e8 - #1292
Closed
trunk-io[bot] wants to merge 8 commits into
Closed
trunk-io[bot] wants to merge 8 commits into
trunk-io[bot] wants to merge 8 commits into
Conversation
Cross-compile trunk-analytics-cli for powerpc64le-unknown-linux-gnu and s390x-unknown-linux-gnu, smoke-test both under QEMU, and build them on every PR. Both link glibc dynamically; Cross.toml pins the cross 0.2.5 images so the floor stays at glibc 2.22/2.18 rather than 2.39. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cross installs a missing target itself, so rust-toolchain.toml does not need ppc64le and s390x. The glibc check now fails above 2.28 (RHEL 8) instead of only logging the floor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Linked in the cross 0.2.5 image, the ppc64le binary dies with SIGILL at startup on glibc 2.34 and newer (RHEL 9, Ubuntu 24.04). Link it with zig against glibc 2.28 instead. The cross 0.2.5 release ignores the zig setting, so the glibc targets build with cross at a pinned commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The build jobs shared one rust-cache key across every Linux x64 target, so s390x could restore build scripts compiled for a newer glibc and run them in its Ubuntu 16.04 image. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Trunk drops every report that has old (> 24 hour) timestamps when it ingests an upload. The summary only said so in each file's warnings, which the file limit cuts off, so a run could show passing tests that Trunk then dropped. The upload and validate summaries now say how many files have old timestamps, that Trunk will drop their results, and that the test counts include them. They also suggest --bazel-bep-path, which skips results that Bazel restored from its cache. The line is never truncated and shows with --validation-report none too. The JSON summary gets filesWithOldTimestamps and a per-file oldTimestamps, and github-annotations adds a warning. Exit codes and uploads don't change. Refs TRUNK-23000 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1292 +/- ##
==========================================
+ Coverage 85.81% 86.05% +0.24%
==========================================
Files 85 85
Lines 19395 19447 +52
==========================================
+ Hits 16643 16735 +92
+ Misses 2752 2712 -40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
trunk-io
Bot
deleted the
trunk-merge/pr-1281/e6868de7-3098-4b32-ba22-a36d514361e8
branch
November 4, 2026 21:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created and is being managed by Trunk Merge.
This pull request is based on the main branch at SHA b66484586c58288bc3ddb05b4e33910dd52c40f5.
See more details here.
When CI completes, this pull request will be closed automatically.
Pull Requests Being Tested
This pull request is testing the changes from pull request 1281.
Dependencies
This pull request depends on the changes from pull request 1278.