Fix non-functional File Creation Mask in Preferences Expert module#542
Open
armm77 wants to merge 1 commit into
Open
Fix non-functional File Creation Mask in Preferences Expert module#542armm77 wants to merge 1 commit into
armm77 wants to merge 1 commit into
Conversation
The File Creation Mask grid rendered empty and did nothing because the WMPermissions custom view composites its PermYes/PermNo/PermNoChange TIFF glyphs from the module bundle, but those resources existed only in the Workspace Inspectors and were never bundled into Expert.preferences, so pathForResource: returned nil. The controller also never finished wiring the view: displaysExecute was left NO (hiding the Execute row), the matrix was never seeded, and changes were neither captured nor persisted. Make Preferences File Creation Mask take effect immediately - Expert.m: post the distributed notification after persisting the mask. - Controller.m: apply the saved umask on startup, observe the notification, and re-apply on change. - Bundle PermYes/PermNo/PermNoChange.tiff with the Expert module. - Locate the WMPermissions view in awakeFromNib, enable the Execute row, seed it from the saved umask (falling back to the process umask), and set target/action. - Persist the chosen mask to OSEDefaults (NXFileCreationMask) as a POSIX umask on change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The File Creation Mask grid rendered empty and did nothing because the WMPermissions custom view composites its PermYes/PermNo/PermNoChange TIFF glyphs from the module bundle, but those resources existed only in the Workspace Inspectors and were never bundled into Expert.preferences, so pathForResource: returned nil. The controller also never finished wiring the view: displaysExecute was left NO (hiding the Execute row), the matrix was never seeded, and changes were neither captured nor persisted.
Make Preferences File Creation Mask take effect immediately