Repository navigation
fix(dispute): report oversized archive payload accurately - #765
Closed
dannyward630 wants to merge 1 commit into
Closed
dannyward630 wants to merge 1 commit into
dannyward630 wants to merge 1 commit into
Conversation
Addresses trustflow-protocol#756. Assisted-by: Codex (GPT-6)
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #756. Assisted by Codex (GPT-6).
Description
Closes #756
The archive service warned that oversized dispute archives were being truncated, but it actually sent the complete JSON payload to the uploader. This change makes the warning accurate and measures the serialized payload in UTF-8 bytes against the 256 KiB recommendation.
Type of Change
Component
Changes Made
Testing
Manual Testing
Not performed; this change is covered by focused automated tests.
Automated Testing
Focused test passed (6 tests):
npm test -- --runInBand --globals='{"ts-jest":{"diagnostics":false}}' dispute/arweave-archive.service.spec.ts.Focused Prettier check passed for both changed files; focused ESLint check passed for the spec file.
The repository build and full test suite currently fail on unrelated existing TypeScript and test errors elsewhere in the codebase. The standard type-checked focused Jest invocation is blocked by an existing
src/webhook/webhook.service.tserror (OutboxService.sendWebhookis missing). No diagnostics from the filtered TypeScript run refer to the changed files.Checklist
Additional Notes
The PR is a draft because the repository-wide build and test suite are currently blocked by unrelated errors. I left the remaining self-review and manual testing checkboxes unchecked.