Fix unreachable code and missing validation across multiple services

[opeaceooo]

Summary

Fixes four critical issues where code paths were unreachable or missing validation:

• Fix PLACEHOLDER_JWT_SECRETS check in env.config.ts is unreachable because the length check runs first #749: JWT_SECRET placeholder validation was unreachable due to length check running first
• Fix GigExpiryWorkerService references MetricsService, SentryService and LOCK_RENEWAL_INTERVAL_MS without importing or defining them #761: GigExpiryWorkerService had unimported dependencies and undefined constant
• Fix DeliverableStatus.PENDING and FAILED are unreachable — a degraded pin never shows up on the deliverable record #757: Deliverable PENDING and FAILED statuses unreachable due to always setting PINNED
• Fix assignJurors allows an even juror count, letting ties silently resolve to SPLIT with no record that voting tied #764: assignJurors allowed even juror counts, enabling silent vote ties

Changes

env.config.ts

• Reordered JWT_SECRET validation checks: placeholder check now runs before length check
• This ensures placeholder values like 'secret' or 'change-me-in-production' are caught with appropriate error message

gig-expiry-worker.service.ts

• Added missing imports: MetricsService and SentryService
• Defined LOCK_RENEWAL_INTERVAL_MS constant (10 seconds) for lock renewal during long sweeps

deliverable.service.ts

• Added import for PinStatus from ipfs-pinning types
• Added mapPinStatusToDeliverableStatus() method to map IPFS pin states to deliverable states
• Updated upload() to use pin result status: HEALTHY → PINNED, DEGRADED → PENDING, FAILED → FAILED
• This ensures degraded pins are properly tracked and can be monitored

dispute-saga.service.ts

• Added validation in assignJurors() to reject even juror counts
• Prevents vote ties which previously resolved silently to SPLIT with no record

Closes #749
Closes #761
Closes #757
Closes #764

[drips-wave]

@opeaceooo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits