Repository navigation
Fix JWT secret rotation, milestone persistence, test paths, and analytics validation - #776
Merged
meshackyaro merged 4 commits intoOct 18, 2026
Conversation
…nciliation re-fetch - trustflow-protocol#756: ArweaveArchiveService now actually truncates oversized dispute archives instead of only logging a warning; falls back to a minimal stub if still too large - trustflow-protocol#763: GraphQL escrows query now accepts offset/limit args and returns EscrowPage (data, total, offset, limit) matching the REST list pagination contract - trustflow-protocol#758: Supertest integration tests enable URI versioning on the Nest app so /v1/reputation/* routes resolve instead of 404ing - trustflow-protocol#750: EscrowReconciliationService fetches the full escrow list once and filters in-memory, eliminating the O(n) re-fetch loop that called findAll on every batch
…rsioning-reconciliation
…tics validation - Support JWT_SECRET_PREVIOUS for graceful secret rotation (trustflow-protocol#745) JwtStrategy now verifies tokens against both current and previous secrets using getJwtVerificationSecrets() with secretOrPublicKeyProvider - Persist milestone approvals to Redis (trustflow-protocol#747) approveMilestone() now saves approved milestones to Redis, fixing non-functional milestone approval system. Adds MILESTONE_KEY_PREFIX and milestoneKey() helper. - Remove /v1 prefixes from test paths (trustflow-protocol#752) idempotency.integration.spec.ts and security-headers.spec.ts were asserting against /v1-prefixed paths that test apps never configured - Add limit parameter validation to GET /admin/analytics/escrows (trustflow-protocol#746) Validates limit is a positive integer, returns 400 on invalid input instead of crashing with raw Redis errors Closes trustflow-protocol#745 Closes trustflow-protocol#746 Closes trustflow-protocol#747 Closes trustflow-protocol#752
|
@Big-JoshCode Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
#745 JWT Secret Rotation
#747 Milestone Persistence
#752 Test Path Corrections
#746 Analytics Limit Validation
Closes #745
Closes #746
Closes #747
Closes #752