Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Factors gateway URL normalization (
replace(/\/+$/, '')+ ensuring the/ipfspath segment) out ofIPFSStorage.resolve()into shared helpers (normalizeGatewayUrlandbuildGatewayCidUrl) and usesbuildGatewayCidUrlinIPFSStorage.upload(). This ensuresupload()returns the exact same gateway URL thatresolve()requests when a customgatewayUrlis configured without an/ipfssuffix or with trailing slashes.Linked Issue
Closes #504
Type of Change
docs/VERSIONING.md; add a### ⚠️ Breaking Changeschangelog entry and adocs/UPGRADING.mdsection)Checklist
Code Quality
anytypes in public APIsnpm run format:checkto verify)npm run lintnpm run typecheck(andnpm run typecheck:testsif tests were modified)Testing
npm run testnpm run test:coverageto check)Documentation
CHANGELOG.mdupdated with entry under[Unreleased]section, formatted as:docs/API.md) updated if public API changeddocs/ARCHITECTURE.md) updated if module structure/patterns changedGeneral
fix/[issue-number]orfeature/[description]Notes
Verified with
npx jest tests/storage.test.ts tests/storage-resolve.test.ts,npm run typecheck,npm run lint, andnpx prettier --check.