Repository navigation
Document via tenting props with live previews - #940
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Abse2001
approved these changes
Oct 9, 2026
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: https://docs-cqnoc797n-tscircuit.vercel.app/elements/via
The
<via />and<board />references omit the existing tenting props. Documenttentedvalues anddefaultViaTentinginheritance, including an explicitfalseoverriding the board default.Add readable TSX examples for exposed, both-side, top-only, and bottom-only tenting, plus board defaults and per-via overrides. Both examples use CircuitPreview's live renderer. Add an opt-in
showSolderMaskpreview prop that forwardsshow_solder_mask=true; existing previews keep their default behavior.Validation:
5c51dbb.Live preview verification: The renderer update is merged in svg.tscircuit.com #2521: SVG
0.0.445and GLTF0.0.152. Fresh live PCB responses now include dark-center shading. FreshCache-Control: no-cache3D requests for both documentation examples also show the expected dark centers: Both sides and Top only in the via example, and Inherited and Both sides in the board-default example. Exposed vias retain exposed copper. Both 3D responses returned HTTP 200,X-Svg-Cache: MISS, andAge: 0; the remaining live-renderer blocker described earlier is resolved for these top-view examples.Preview pages: