Skip to content

Document via tenting props with live previews - #940

Merged
techmannih merged 3 commits into
mainfrom
docs/via-tenting-examples
Oct 9, 2026
Merged

techmannih merged 3 commits into
mainfrom
docs/via-tenting-examples

Conversation

@techmannih

@techmannih techmannih commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

test: https://docs-cqnoc797n-tscircuit.vercel.app/elements/via

The <via /> and <board /> references omit the existing tenting props. Document tented values and defaultViaTenting inheritance, including an explicit false overriding the board default.

Add readable TSX examples for exposed, both-side, top-only, and bottom-only tenting, plus board defaults and per-via overrides. Both examples use CircuitPreview's live renderer. Add an opt-in showSolderMask preview prop that forwards show_solder_mask=true; existing previews keep their default behavior.

Validation:

  • Build, typecheck, formatting, and the Vercel preview pass on refresh commit 5c51dbb.
  • The earlier local validation passed all 18 tests. Both TSX examples compile and typecheck; top/bottom tenting states and drill diameters were verified in the generated Circuit JSON.
  • The refreshed preview routes load and continue to use the hosted renderer.

Live preview verification: The renderer update is merged in svg.tscircuit.com #2521: SVG 0.0.445 and GLTF 0.0.152. Fresh live PCB responses now include dark-center shading. Fresh Cache-Control: no-cache 3D requests for both documentation examples also show the expected dark centers: Both sides and Top only in the via example, and Inherited and Both sides in the board-default example. Exposed vias retain exposed copper. Both 3D responses returned HTTP 200, X-Svg-Cache: MISS, and Age: 0; the remaining live-renderer blocker described earlier is resolved for these top-view examples.

Preview pages:

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 9, 2026 5:46am UTC

Request Review

@techmannih techmannih changed the title Document via tenting props with labeled examples Document via tenting props with live previews Oct 9, 2026
@techmannih
techmannih merged commit 2572c10 into main Oct 9, 2026
5 checks passed
@tscircuitbot

Copy link
Copy Markdown

Thank you for your contribution! 🎉

PR Rating: ⭐
Impact: Tiny

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


This branch was successfully deployed

1 active deployment
Preview — 5c51dbbd Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants