Repository navigation
Add NEMA34 motor support - #116
Merged
Merged
Conversation
seveibar
marked this pull request as ready for review
October 10, 2026 23:23
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
nema34strings andnemaSize: 34to the shared NEMA contract. The representative 86 × 80 mm envelope, 69.6 mm mounting pitch, 6.5 mm through-flange holes, 73 mm pilot, and 14 × 32 mm round shaft follow the STEPPERONLINE dimension drawing; the keyway is omitted.NEMA34 defaults now follow the supplied STEPPERONLINE product photo: a rounded stepped body/rear profile, plain rear casting, and 2 mm wires with a 25 mm visible length exiting at 90 degrees beside the rear of the body.
cornerProfile/stepped/chamferedandrearCornerChamfer/rearchamferconfigure the profiles. Shoulder depth is the chamfer value divided by sqrt(2), with fillets up to 4 mm; default body/rear values are 24 mm. Optional rear bores/screws use an illustrative 40 mm pitch. These photo-based details are not manufacturing dimensions or frame guarantees.Wire references follow the stepped outline, including diagonal exits and hidden wires. Validation checks through-hole clearance, optional rear screw clearance, and wire/connector fit. Existing NEMA8/17/23 default definitions remain covered.
Validation: all 236 tests pass (4951 assertions), plus typecheck, format check, and build. Geometry and visual preview: tscircuit/jscad-electronics#500.