Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
solidrivetparameter contract requested in #13 (item 0036): an unset solid cylindrical shank, spherical-cap head, and flat tail with explicit dimensions. Both the roadmap string and value-free head/tail/state flags resolve to the same strict, millimeter-normalized definition. The bearing-plane datum and derived head-sphere dimensions are documented for renderer integration.The change adds one model folder, parameter tests, and its contract documentation. Registry discovery handles public exports and the model union. There are no meshes, renderer dependencies, generated files, or changes to existing models.
Validation on macOS:
model-registration-07-generation.test.tsfailure reproduces on untouched upstreamff02644c4a9b55bacfe63573c852d03c182a564f: Bun cannot import the temporary fixture'srevision-2.ts. This PR does not modify that test or the registry generator.bun run typecheck,bun run format:check, andbun run buildpass.Prepared and validated with OpenAI Codex assistance; no human code review is claimed. This implements the modelprinter contract only; geometry generation remains in jscad-electronics as required by the repository conventions.