Guard getColorFromString against NaN hue for very long strings#652
Open
abdalraof-albarbar wants to merge 1 commit into
Open
Guard getColorFromString against NaN hue for very long strings#652abdalraof-albarbar wants to merge 1 commit into
abdalraof-albarbar wants to merge 1 commit into
Conversation
For a long enough string the `acc * 31 + charCodeAt` accumulator overflows to Infinity, so `hash % 360` is NaN and the function returns an invalid `hsl(NaN, 100%, 50%, 1)` color. Fall back to a valid hue when the hash isn't finite; every finite hash keeps the exact same output. Co-authored-by: abdalrouf-AAA <236259618+technologyet31-create@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #651
The hash accumulator overflows to
Infinityfor long strings, sohash % 360came outNaNand the color washsl(NaN, ...). This falls back to a valid hue when the hash isn't finite — every finite hash keeps the exact same output, so no existing colors change. Added a small test.