Add a repro test for net labels placed inside chip bodies#656
Open
abdalraof-albarbar wants to merge 1 commit into
Open
Add a repro test for net labels placed inside chip bodies#656abdalraof-albarbar wants to merge 1 commit into
abdalraof-albarbar wants to merge 1 commit into
Conversation
In bug-report-20260707T230831Z the final placement leaves four net labels (VIN, VOUT, PG and "U1.FB to R2.pin1") fully inside chip bodies, where they render behind the component and are illegible. NetLabelNetLabelCollisionSolver only relocates a label when it overlaps another label, so a label that sits inside a chip without also colliding with a label is never checked against chips or moved out. Marked test.failing so CI stays green until the placement is fixed. Co-authored-by: abdalrouf-AAA <236259618+technologyet31-create@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro for #655.
bug-report-20260707T230831Zends up with four net labels (VIN,VOUT,PG,U1.FB to R2.pin1) placed fully inside chip bodies, so they render behind the component and are illegible.NetLabelNetLabelCollisionSolveronly relocates labels that overlap another label, so a label sitting inside a chip is never checked against chips or moved out.