Repository navigation
Fix push up push_up_unary_recombinant_mutations issue - #631
Merged
Merged
Conversation
Count all child edges of a recombinant node, not just full-span ones, when deciding whether it is unary. Previously a recombinant with one full-span child and other partial-span children was treated as unary, so mutations pushed up onto it were inherited by the other children, giving a bad mutation parent error.
This was added as a workaround for the push_up_unary_recombinant_mutations bug, which is now fixed.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #631 +/- ##
=======================================
Coverage 88.68% 88.68%
=======================================
Files 12 12
Lines 4320 4322 +2
Branches 620 621 +1
=======================================
+ Hits 3831 3833 +2
Misses 361 361
Partials 128 128
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.