fix(bazel): use python3 instead of perl for unzip_src patch_cmds - #273
Draft
tstapler wants to merge 1 commit into
Draft
fix(bazel): use python3 instead of perl for unzip_src patch_cmds#273tstapler wants to merge 1 commit into
tstapler wants to merge 1 commit into
Conversation
perl isn't guaranteed present on every CI runner image; python3 is preinstalled on both macOS and Linux runners and performs the same portable in-place edit without BSD sed's -i quirks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
perl -pi -ein-place edit in MODULE.bazel'sunzip_srcpatch_cmdsfor an equivalentpython3 -ccommand, at Tyler's request.gmtime()/localtime()declarations in#if !defined(__GLIBC__) && !defined(linux)), just a different portable interpreter.Test plan
bazel clean --expungethenbazel build @unzip_src//:unzipfrom cold — genuine 28-action fetch → patch → compile (ubz2err.c) → link, zero cache hits, build succeeded.