[rjb32]

Name the type of an imported property in one spec.

[rjb32]

Note

AI-generated summary.

Summary

Goal. Before points could be imported, fold DateTimeSpec and DurationSpec into one spec. They were two identical name sets threaded side by side through about 25 files, and a third copy for points would have added a third parameter everywhere.

Approach. TypedPropertySpec maps a property name to the ValueType the import reads it as. WITH DATETIMES and WITH DURATIONS fill it, and the system ops carry one types dictionary of name to element type ({at = !storage.datetime}) in place of date_times and durations. A name given two types keeps the first and is recorded as a clash, which the analyzer rejects with the same message as before. LOAD syntax and behaviour are unchanged.

Where to look.

• import/common/TypedPropertySpec.h:14: the spec and its clash record
• query/analyzer/CypherAnalyzer.cpp:1897: clash and embedding checks over the one spec
• query/ir/dialect/db/DBSystemOps.td:93: the types attribute
• query/ir/exec/NLSystemTranslator.cpp:178 fillTypedPropertySpec

-importGraph(path, name, embeddings, dateTimes, durations)
+importGraph(path, name, embeddings, typedProperties)
-db.import_graph ... datetimes {at} durations {took}
+db.import_graph ... types {at = !storage.datetime, took = !storage.duration}

Evidence

• Before: two spec classes and two attributes.
  After: no behaviour change.

  JSONL datetime, duration, clash, null, edge-endpoint tests; Parquet import and duration tests;
  parser keyword, edge-case and AST comparator tests; system import tests:  18/18 passed
  

Merge Danger

Door: two-way

Blast Radius: import

The IR attribute of db.import_graph and nl.import_graph is renamed. No stored data and no query syntax change.