[rjb32]

Enable the tests that query parameters, collect() of a map and a literal map index now let pass.

JourneyLegsTest.readsTheWindowFromParameters                         was disabled on TUR-48
JourneyParetoTest.collectsTheLegsAsMaps                              was disabled on TUR-100
PatternFromATaggedCellTest.startsAMatchFromANodeReadByALiteralIndex  was disabled on m['person']

journey_planner_npm  reads the window from parameters                 new, the C++ query through npm
journey_planner_npm  5 parameter cases                                WITH constants -> $parameters
journey_planner_npm  returns every kind of value a parameter map holds  was parse-only

journey_planner_npm: 164 passed, 0 failed

[rjb32]

Note

AI-generated summary.

Summary

Goal. Turn on the tests that were waiting for query parameters (TUR-48), collect() of a map (TUR-100) and a literal map index (m['person']). All three have landed on main. The three disabled tests now pass without changes.

Approach. This PR changes tests only. Three C++ tests drop DISABLED_. The npm journey test now runs the customer's leg search with $depart_from and $depart_before. Its parameter cases had declared their values with WITH because the engine could not read a value parameter. They now send them as parameters.

Where to look.

• regress/journey_planner_npm/cypher.ts:509 PARAMETER_CASES: the cases that moved from WITH constants to $parameters
• regress/journey_planner_npm/journey.ts:212 "reads the window from parameters": the query of JourneyLegsTest.cpp:165, sent through the npm client

 PARAMETER_CASES
-  WITH 470 AS integer, 2.5 AS ratio, ... RETURN integer, ratio, ...
+  RETURN $integer, $ratio, ...                      {integer: 470, ratio: 2.5, ...}
-  WITH ['OXF', 'PAD'] AS stops MATCH (s:STATION) WHERE s.crs IN stops RETURN s.name
+  MATCH (s:STATION) WHERE s.crs IN $stops RETURN s.name    {stops: ['OXF', 'PAD']}
-  MATCH (s:$label) RETURN count(s)                  {unused: [one value of every kind]}
+  MATCH (s:$label) RETURN count(s), $values         {values: [one value of every kind]}

Evidence

• Before: on e75b0f187, the three tests are skipped. Each passes when forced with --gtest_also_run_disabled_tests:

  JourneyLegsTest.DISABLED_readsTheWindowFromParameters                          OK
  JourneyParetoTest.DISABLED_collectsTheLegsAsMaps                               OK
  PatternFromATaggedCellTest.DISABLED_startsAMatchFromANodeReadByALiteralIndex   OK
  

  After:

  test_query_ir_journey_legs                 11 passed
  test_query_ir_journey_pareto               17 passed, 1 disabled (sortsTheLegsWithSortMulti, TUR-298)
  test_query_ir_pattern_from_a_tagged_cell   53 passed, 5 disabled (SET/REMOVE/DELETE TUR-370, shortest path)
  journey_planner_npm                        164 passed, 0 failed
  

  journey_planner_npm ran on a package rebuilt with ./build_npm.sh, on private ports rather than through run.sh.

Merge Danger

Door: two-way

Blast Radius: tests

The PR changes only test files. CI now runs four more queries over parameters, collect() of a map and m['key']. A regression in any of them fails CI instead of going unnoticed.