Repository navigation
fix: preserve repeated buffer and DataView references - #29
Open
feritcemkahraman wants to merge 1 commit into
Open
feritcemkahraman wants to merge 1 commit into
feritcemkahraman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deserializing an object that references the same ArrayBuffer or DataView twice creates two separate objects. That also breaks Map lookups using one of those restored references.
Cache both restored types by their serialized record index, as the other types already do. The regression fails before the fix and checks repeated references, Map keys/values, and bytes through both serializer and JSON round trips. Regenerated the CJS and browser bundle outputs.
Validation: the full build and test suite pass with 100% statement, branch, function, and line coverage. Six additional ESM/browser-bundle round-trip checks pass. Terser used one worker locally; the browser/Node version matrix was not run. This does not change DataView slice handling in #28.