Skip to content

fix: install ring as the default rustls provider #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WeissDev merged 1 commit into from
Sep 30, 2026
Merged

fix: install ring as the default rustls provider #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions patches/matrix-rust-sdk-ring-provider.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,19 @@ index fe4e3da..dd66fd3 100644
rustls-pki-types = "1.14.0"
rustls-native-certs = "0.8.3"
webpki-roots = "1.0.6"
diff --git a/crates/matrix-sdk/src/http_client/native.rs b/crates/matrix-sdk/src/http_client/native.rs
index a02455f..71d4419 100644
--- a/crates/matrix-sdk/src/http_client/native.rs
+++ b/crates/matrix-sdk/src/http_client/native.rs
@@ -185,6 +185,11 @@ impl Default for HttpSettings {
impl HttpSettings {
/// Build a client with the specified configuration.
pub(crate) fn make_client(&self) -> Result<reqwest::Client, HttpError> {
+ // reqwest is built with `rustls-no-provider`, so it panics with "No provider
+ // set" unless a process-wide default exists. Only the Android verifier below
+ // installs one implicitly. This fails harmlessly if one is already installed.
+ let _ = rustls::crypto::ring::default_provider().install_default();
+
let user_agent = self.user_agent.clone().unwrap_or_else(|| "matrix-rust-sdk".to_owned());
let mut http_client = reqwest::Client::builder()
.user_agent(user_agent)
Loading