Repository navigation
Conversation
…今いる場所(地面の山か、合わさったカタマリ)へ付け直す。これまでは指を離していないのに、その瞬間に隕石が外れていた
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
何が起きていたか
指を離していないのに、運んでいる隕石が途中で外れることがあった。掴みは「どのカタマリの何列目の何番目か」という添字で覚えていて、カタマリの形が変わると指す先がずれるため、次の場面では掴みごと捨てていた。
変えたこと
Game.rebindDragsを足し、形が変わる前に控えた「指 → 隕石」から、隕石の今いる場所(地面の山か、どのカタマリか)を探して掴みを付け直す。盤面から消えた隕石だけ離すupdateLumpsのドッキングと着地、igniteの最後で付け直す。点火で持ち上げる隕石そのものを掴んでいた指と、レアメタルで壊れた列の指は、これまでどおり離す確かめたこと
tests/core/drag.test.tsに 4 件足し、修正前のコードで 4 件とも落ちることを確かめたpnpm typecheck/pnpm test/pnpm check:names