Repository navigation
次の惑星の出だしに前の惑星の吹き出しが残らないよう、盤面を始めるたびに重ねた効果を片付ける - #7
Merged
Merged
Conversation
…粒・帯・揺れなど盤面に重ねたものをすべて片付ける
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
惑星めぐりで次の惑星へ渡ると、前の惑星で出した「10 CHAIN」や「+3」が新しい盤面の出だしに残っていた。
Effects.clear()を足し、吹き出し・粒・輪・閃き・光の柱・帯・攻撃の弾・揺れ・閃光をまとめて片付けるbeginPlayでこれまでのresetShow()(決着の演出だけ)の代わりに呼ぶ。1 人用の「もう一度」や対戦のリベンジも同じ道を通る確認: 追加した e2e(
e2e/effects.spec.ts「新しい盤面を始めると、前の盤面の吹き出しと帯は残らない」)が修正前に落ちることを確かめた。typecheck・e2e/effects.spec.ts・e2e/versus.spec.ts・e2e/tour.spec.ts