Repository navigation
feat(honors): Latin honors GWA counts only the required electives - #122
Merged
Merged
Conversation
The UPLB catalog counts only as many electives toward Latin honors as the program requires, the earliest first. Extra passed courses that fill no slot stay in the GWA but leave the honors GWA, which now drives the honor badge. The GWA card names every course it left out, so a data gap is visible instead of silent. Programs with no elective slots skip this. Claude-Session: https://claude.ai/code/session_01T3dKAgr7Yo2637teHP4vNU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #121
The UPLB catalog (Graduation with Honors) counts only as many electives toward Latin honors as the program requires, taken in date order. GradeSim counted every passed course.
surplusElectivesinrequirements.jsreusesfillRequirementSlots. It returns passed academic rows that fill no named course, GE, specialization or elective slot.Caveat. The source is the 2016-era general rules volume, which the OUR site still links, so confidence is medium. The catalog's shiftee priority order (graduating program first, then accepted electives from the old program) is simplified to date order. Because the card lists what it left out, a wrong call is visible and the user can fix it with "Leave out of GWA" or a substitution.
Checks
extension/*.test.jspass. New tests cover the two latest extras being dropped, no surplus when electives fit, and no guessing without elective slots.https://claude.ai/code/session_01T3dKAgr7Yo2637teHP4vNU