Skip to content
This repository was archived by the owner on Jan 2, 2025. It is now read-only.
This repository was archived by the owner on Jan 2, 2025. It is now read-only.

Proposal: Remove assetId as requirement and make grouping optional #27

Description

@jayqi

Right now append_slope_features requires a column named "assetId" which it will use to group observations for the purpose of calculating stateful features. I believe this is unnecessarily opinioned about how users are using groundhog. I propose we remove this requirement, and instead include an optional parameter to specify a grouping column. This means that a user with observations for only one entity will not need to make a dummy assetId column.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingenhancementNew feature or requestquestionFurther information is requested

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions