ci: modified codeql-action steps to have the same version - #916
ci: modified codeql-action steps to have the same version#916OdysseasKalaitsidis wants to merge 3 commits into
Conversation
✅ Deploy Preview for urunc canceled.
|
|
To prevent this from happening again, we need to update dependabot.yaml and group these 3 together so there is no drift |
Yeap, that sounds a good idea. Let;s add it in this PR. |
|
Totally agree, adding the changes to the dependabot.yaml to the PR. |
|
Thank you @OdysseasKalaitsidis , you will also need to add yourself in https://github.com/urunc-dev/urunc/blob/main/.github/contributors.yaml |
|
@cmainas thank you for the instruction, added myself as odykal on contributors.yaml |
Hey, you also removed some of the past contributors. Also, ensure that the commits are DCO-signed and there are no merge commits. |
|
@Nachiket-Roy Thank you for appointing the issues with my PR. Fixing, wont happen again |
The init, autobuild and analyse in codeql.yml had drifted to different CodeQL versions 4.37.4 vs 4.36.2, causing codeql runs to fail Fixes: urunc-dev#915 Signed-off-by: Odysseas Kalaitsidis <odysseaskalaitsides@gmail.com>
Modified dependabot.yml to group codeql-action so dependabot groups all steps together in a single PR instead one at a time, preventing the version drift that caused urunc-dev#915 Signed-off-by: Odysseas Kalaitsidis <odysseaskalaitsides@gmail.com>
Signed-off-by: Odysseas Kalaitsidis <odysseaskalaitsides@gmail.com>
0ae62ce to
822dda5
Compare
3 participants
Description
After investigating the CodeQL workflow, I found that commit 9d371bc changed only the init step to v4.37.4 but left the autobuild and analyze steps on the older version of v4.36.2. Since all steps come from the same codeql-action and need to stay on the same version, the version drift caused the init to write a config file newer than the analyze could read and the run failed with
"Loaded a configuration file for version '4.37.4', but running
version '4.36.2'"
The PR modifies the codeql.yml to point to the same new version v4.37.4
Related issues
Fixes #915
How was this tested?
I pulled the actual failed run 31158525443 to confirm the error and checked via GitHub API the version tag and the commit SHA it points to. It confirmed that the init step new SHA is the v4.37.4 so the comment # v3.29.5 next to it in the file was wrong and that the old SHA is still used by the autobuild and analze which was the v4.36.2
LLM usage
Claude Sonnet 5 assisted me in investigating the failing run. I reviewed the diagnosis and the fix myself before submitting this PR.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).