Skip to content

feat(settings): pick the MAC address source from a bottom sheet - #97

Merged
usamaiqb merged 1 commit into
mainfrom
feat/mac-access-sheet
Oct 13, 2026
Merged

usamaiqb merged 1 commit into
mainfrom
feat/mac-access-sheet

Conversation

@usamaiqb

Copy link
Copy Markdown
Owner

Replace the segmented buttons with a picker sheet like the language one. Each option shows whether it is ready, will prompt, or is unavailable; the sheet stays open while access is requested and shows a refusal inline instead of a Toast.

Checklist

  • PR title follows Conventional Commits
  • ./gradlew test and ./gradlew lint pass locally
  • UI changes include screenshots / screen recordings (if applicable)

Replace the segmented buttons with a picker sheet like the language one. Each
option shows whether it is ready, will prompt, or is unavailable; the sheet
stays open while access is requested and shows a refusal inline instead of a
Toast.
@usamaiqb usamaiqb self-assigned this Oct 12, 2026
@usamaiqb

Copy link
Copy Markdown
Owner Author

@martinellimarco can you please take a look

@martinellimarco

Copy link
Copy Markdown
Contributor

@usamaiqb I've tested this on two devices, one using Shizuku and the other rooted, both with the permission granted and denied. Everything works fine for me.

@usamaiqb
usamaiqb merged commit be437aa into main Oct 13, 2026
4 checks passed
@usamaiqb
usamaiqb deleted the feat/mac-access-sheet branch October 13, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants