Repository navigation
feat(settings): pick the MAC address source from a bottom sheet - #97
Merged
Merged
Conversation
Replace the segmented buttons with a picker sheet like the language one. Each option shows whether it is ready, will prompt, or is unavailable; the sheet stays open while access is requested and shows a refusal inline instead of a Toast.
Owner
Author
|
@martinellimarco can you please take a look |
Contributor
|
@usamaiqb I've tested this on two devices, one using Shizuku and the other rooted, both with the permission granted and denied. Everything works fine for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the segmented buttons with a picker sheet like the language one. Each option shows whether it is ready, will prompt, or is unavailable; the sheet stays open while access is requested and shows a refusal inline instead of a Toast.
Checklist
./gradlew testand./gradlew lintpass locally