Skip to content

feat/rascal formatter - #1102

Merged
DavyLandman merged 77 commits into
mainfrom
feat/rascal-formatter
Sep 2, 2026
Merged

feat/rascal formatter#1102
DavyLandman merged 77 commits into
mainfrom
feat/rascal-formatter

Conversation

@jurgenvinju

@jurgenvinju jurgenvinju commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This work by @toinehartman and YT introduces the Rascal formatter to VScode.

  • links the Rascal formatter from the stdlib to the formatDocument and formatSelection capabilities in LSP for Rascal
  • maps all FormattingOptions, taken from: Parametric: formatting #677
  • support for formatting only a selection via the Focus mechanism, also taken from Parametric: formatting #677
  • works with subTreeEditFormatter from util::Formatters correctly
  • adds two UI tests, one for whole file formatting and one for selection formatting

@toinehartman
Rascal LSP formatting API and example.
630ccc4
@toinehartman
Provide overridable defaults for common string operations.
d3675c4
@toinehartman
Align names with DocumentFormattingParams
b32d2f6
@toinehartman
Implement parametric formatting.
f16e17a
@toinehartman
Ongoing design work.
b749dcf
@toinehartman
Experiment with a first formatting implementation using Box.
f1effe1
@toinehartman
Simplify API and shift responsibilities towards DSL.
6fc3acf
@toinehartman
Improve names in formatting library.
bdb7989
@toinehartman
Add indentation conversion functions.
a985a81
@toinehartman
Do string modifications in Pico formatter.
0196d07
@toinehartman
Update formatting API design.
d1c4e3e
@toinehartman
Add mergeLines
49b66d0
@toinehartman
Small fixes.
998a115
@toinehartman
Break new line ties by order.
551fe2a
@toinehartman
Document & fix string/formatting utils.
84c5a35
@toinehartman
Add rangeFormatting, reuse formatting.
c4b3561
@toinehartman
Match contribution sig in implementation.
1748678
@toinehartman
Add missing license header.
1d56010
@toinehartman
Document formatting service.
20a71ae
@toinehartman
Use formatter from stdlib.
cda1531
@toinehartman
Change defaults based on discussion with @DavyLandman.
206a57a
@toinehartman
Fix import to renamed module.
6cdab51
@toinehartman
Format Pico examples.
05b2955
@toinehartman
Inline function.
9561883
@toinehartman
Use focus instead of Tree+loc.
7b92033
@toinehartman
Implement range focus with special case for lists.
244da24
@toinehartman
Fix comment about Rascal charcter encoding.
69307a7
@toinehartman
Add basic TreeSearch tests.
c1b08a8
@toinehartman
Consider layout as well.
6f5657f
@toinehartman
Include partially selected element at end of range.
49cf9be
@jurgenvinju
factored FormattingOptions converter for reuse by rascal and lsp server
9b47c0f
@jurgenvinju
factored and reused formatting options converter
a5f18cb
@jurgenvinju
fixed ambiguous overload for formatter function of Pico
d8fc8eb
@jurgenvinju
Merge branch 'main' into feature/lsp-formatting
07f0e65 
This was a detailed manual merge
@jurgenvinju
fixed a broken merge
9da8b7e
@jurgenvinju
fix missing code
a9b83a6
@jurgenvinju
removed sleep from import
0bc051b
@jurgenvinju
revert chai to version 4 because then it still supported plain js mod…
c7221bb 
…ules.
@jurgenvinju
added missing header
baba15b
@jurgenvinju
Merge branch 'main' into feat/rascal-formatter
75cedf0
@jurgenvinju
Merge remote-tracking branch 'origin/feature/lsp-formatting' into fea…
d50db56 
…t/rascal-formatter
@jurgenvinju
temporarily removed the parametric formatter service implementations …
24dfd0a 
…and API and tests
@jurgenvinju
reset chai to version 6
cf02589
@jurgenvinju
temporarily removed the parametric formatter service implementations …
59a19b2 
…and API and tests
@toinehartman toinehartman mentioned this pull request Aug 28, 2026
Merged
2 tasks
@jurgenvinju jurgenvinju self-assigned this Sep 1, 2026
@jurgenvinju
jurgenvinju marked this pull request as ready for review September 1, 2026 10:38
jurgenvinju
jurgenvinju commented Sep 1, 2026
View reviewed changes

@jurgenvinju jurgenvinju left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this.

Note that some important changes have been inherited from #677 which will be finished later.

DavyLandman
DavyLandman approved these changes Sep 1, 2026
View reviewed changes

@DavyLandman DavyLandman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, I only have a question on a TODO, and the status of that.

Comment thread rascal-lsp/src/main/rascal/lsp/lang/rascal/lsp/Formatter.rsc Outdated
Comment thread rascal-vscode-extension/src/test/vscode-suite/ide.test.ts
@sonarqubecloud

sonarqubecloud Bot commented Sep 2, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
56.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@DavyLandman
DavyLandman merged commit 10216b0 into main Sep 2, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavyLandman DavyLandman DavyLandman approved these changes
@toinehartman toinehartman Awaiting requested review from toinehartman

Assignees

@jurgenvinju jurgenvinju

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jurgenvinju @DavyLandman @toinehartman