Skip to content

[POM-leading for DSLs] Server lifetime, bugs and simplification - #1156

Open
toinehartman wants to merge 49 commits into
feature/1010-pom-leading-for-dsls/finalfrom
feature/1010-pom-leading-for-dsls/1086-server-lifetime
Open

[POM-leading for DSLs] Server lifetime, bugs and simplification#1156
toinehartman wants to merge 49 commits into
feature/1010-pom-leading-for-dsls/finalfrom
feature/1010-pom-leading-for-dsls/1086-server-lifetime

Conversation

@toinehartman

@toinehartman toinehartman commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Re-enable exitWhenEmpty, backwards compatible with old versions. Make registerLanguage robust against dying remote servers.
  • Initialize remote servers synchronously. This allows getting rid of servers that could not be initialized and removes the need of using futures in many places.
  • Forward workspace changes to remotes.
  • Other small fixes.

Closes #1086.

@toinehartman
Remove obsolete TODOs.
d97b427
@toinehartman
Propagate workspace folders to remotes.
226d42d
@toinehartman
Fix typos.
3775d13
@toinehartman
Wait for server initialization.
3a1a34b 
Instead of returning a future, wait for server intialization. This makes
sure that no broken servers remain in the remote mapping, and enables
getting rid of futures in many places.
@toinehartman
Populate server info with name.
78feda3
@toinehartman
Extract repeated key name to constant.
ebf8cae
@toinehartman
Extract log writing to dedicated function.
d97ccba
@toinehartman
Throw exceptions on unsupported functions.
5921f2b
@toinehartman
Always set current deploy mode.
68bc3ce
@toinehartman
Exit when empty & retry registration once.
f20ae9e
@toinehartman
Check mismatching versions and suggest fixes.
7234f3e
@toinehartman
Only exit empty server when this argument is known.
aa1ae09
@toinehartman
Remove stale comment.
a49215d
@toinehartman
Throw dedicated exception on unknown language.
ff0e5c6
@toinehartman
toinehartman force-pushed the feature/1010-pom-leading-for-dsls/1086-server-lifetime branch from bc7f48e to ff0e5c6 Compare July 14, 2026 09:32
@toinehartman toinehartman changed the title [POM-leading for DSLs] Server lifetime [POM-leading for DSLs] Server lifetime, bugs and simplification Jul 14, 2026
@toinehartman
toinehartman marked this pull request as ready for review July 14, 2026 15:21
rodinaarssen
rodinaarssen approved these changes Jul 30, 2026
View reviewed changes

@rodinaarssen rodinaarssen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Comment thread ...p/src/main/java/org/rascalmpl/vscode/lsp/parametric/routing/ActualRoutingLanguageServer.java Outdated
Comment thread ...p/src/main/java/org/rascalmpl/vscode/lsp/parametric/routing/ActualRoutingLanguageServer.java Outdated
Comment thread ...p/src/main/java/org/rascalmpl/vscode/lsp/parametric/routing/ActualRoutingLanguageServer.java Outdated
Comment thread ...p/src/main/java/org/rascalmpl/vscode/lsp/parametric/routing/ActualRoutingLanguageServer.java Outdated
Comment thread ...p/src/main/java/org/rascalmpl/vscode/lsp/parametric/routing/ActualRoutingLanguageServer.java Outdated
Comment thread ...sp/src/main/java/org/rascalmpl/vscode/lsp/parametric/routing/RoutingTextDocumentService.java Outdated
Comment thread ...sp/src/main/java/org/rascalmpl/vscode/lsp/parametric/routing/RoutingTextDocumentService.java
Comment thread rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/util/concurrent/CompletableFutureUtils.java Outdated
@toinehartman
toinehartman removed the request for review from DavyLandman August 10, 2026 09:22
DavyLandman
DavyLandman approved these changes Aug 10, 2026
View reviewed changes

@DavyLandman DavyLandman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have some small clarification questions.

Comment thread ...p/src/main/java/org/rascalmpl/vscode/lsp/parametric/routing/ActualRoutingLanguageServer.java Outdated
Comment thread ...p/src/main/java/org/rascalmpl/vscode/lsp/parametric/routing/ActualRoutingLanguageServer.java Outdated
Comment thread ...p/src/main/java/org/rascalmpl/vscode/lsp/parametric/routing/ActualRoutingLanguageServer.java Outdated
Comment thread ...p/src/main/java/org/rascalmpl/vscode/lsp/parametric/routing/ActualRoutingLanguageServer.java Outdated
Comment thread ...sp/src/main/java/org/rascalmpl/vscode/lsp/parametric/routing/RoutingTextDocumentService.java Outdated
Comment thread rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/BaseLanguageServer.java Outdated
@toinehartman toinehartman mentioned this pull request Aug 10, 2026
Draft
@toinehartman
toinehartman force-pushed the feature/1010-pom-leading-for-dsls/1086-server-lifetime branch from ea51242 to 81d5c8a Compare August 13, 2026 12:07
DavyLandman
DavyLandman approved these changes Aug 17, 2026
View reviewed changes

@DavyLandman DavyLandman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks good 👍🏼

Comment thread rascal-vscode-extension/CHANGELOG.md Outdated
@toinehartman toinehartman mentioned this pull request Aug 17, 2026
Merged
DavyLandman added a commit to usethesource/rascal that referenced this pull request Aug 18, 2026
@DavyLandman
Extract path config-based classpath computation (#2847)
dc40443 
Extract/unify computation of a class path given a path config.

This code can also be used to simplify class path computations in the
following PRs:
- usethesource/rascal-language-servers#1159
- usethesource/rascal-language-servers#1156
@toinehartman toinehartman mentioned this pull request Aug 18, 2026
Closed
toinehartman pushed a commit to usethesource/rascal that referenced this pull request Aug 25, 2026
@DavyLandman @toinehartman
Extract path config-based classpath computation (#2847)
0ff9cca 
Extract/unify computation of a class path given a path config.

This code can also be used to simplify class path computations in the
following PRs:
- usethesource/rascal-language-servers#1159
- usethesource/rascal-language-servers#1156
@toinehartman
toinehartman force-pushed the feature/1010-pom-leading-for-dsls/final branch 2 times, most recently from 3d4497d to 0e1240e Compare September 3, 2026 09:49
toinehartman and others added 11 commits September 3, 2026 11:51
@sonarqubecloud

sonarqubecloud Bot commented Sep 3, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
2.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavyLandman DavyLandman DavyLandman approved these changes
@rodinaarssen rodinaarssen rodinaarssen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@toinehartman @DavyLandman @rodinaarssen