Remove std scheme - #1159
Draft
toinehartman wants to merge 51 commits into
Draft
Conversation
toinehartman
force-pushed
the
feature/remove-std-scheme
branch
from
July 20, 2026 07:00
ba7fb37 to
a9bd695
Compare
toinehartman
force-pushed
the
feature/remove-std-scheme
branch
from
July 21, 2026 07:34
8b22840 to
f15c784
Compare
Due to case normalization by VS Code, we need to compare module case. microsoft/vscode#68325
Closes #1147. Co-authored-by: rodinaarssen <rodin.aarssen@swat.engineering>
toinehartman
force-pushed
the
feature/remove-std-scheme
branch
from
July 28, 2026 16:17
3ef3d1f to
b43f9da
Compare
toinehartman
force-pushed
the
feature/remove-std-scheme
branch
from
August 7, 2026 09:01
c0c71ac to
7cf3756
Compare
toinehartman
force-pushed
the
feature/remove-std-scheme
branch
from
August 7, 2026 09:41
7cf3756 to
7b61233
Compare
DavyLandman
reviewed
Aug 12, 2026
| return jars.map(j => path.join(this.jarRootPath, j)).join(path.delimiter); | ||
|
|
||
| private buildTerminalJVMPath(rascalClasses: string[] | undefined): string { | ||
| const lsp = path.join(this.jarRootPath, 'rascal-lsp.jar'); |
Member
There was a problem hiding this comment.
I think this is wrong, as the rascal-lsp dependency should come from the pom.xml not from the extension.
Comment on lines
-46
to
+52
| "title": "Create New Rascal Terminal, Import Module, and Run Main Function" | ||
| "title": "Create New Rascal Terminal, Import Module, and Run Main Function", | ||
| "enablement": "editorLangId == rascalmpl" | ||
| }, | ||
| { | ||
| "command": "rascalmpl.importModule", | ||
| "title": "Create New Rascal Terminal and Import Module" | ||
| "title": "Create New Rascal Terminal and Import Module", | ||
| "enablement": "editorLangId == rascalmpl" |
Member
There was a problem hiding this comment.
Why is this change in this PR?
Member
Author
There was a problem hiding this comment.
Because I was looking for a way to start a REPL in the Pico project from the LSP testing setup, and figured, why can we not open a REPL in a project from a language file (instead of only a Rascal file)? I can find another way to open this REPL and offer these changes in a separate PR, since I still think they are valuable.
DavyLandman
added a commit
to usethesource/rascal
that referenced
this pull request
Aug 18, 2026
Extract/unify computation of a class path given a path config. This code can also be used to simplify class path computations in the following PRs: - usethesource/rascal-language-servers#1159 - usethesource/rascal-language-servers#1156
toinehartman
force-pushed
the
feature/remove-std-scheme
branch
from
August 20, 2026 07:21
4a2931e to
f8c04b4
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to usethesource/rascal#2828
Closes #1151.
Closes #1147.
Closes #1148.
Closes #1149.
Includes the following PRs: