-
Notifications
You must be signed in to change notification settings - Fork 1
Merge dev into main #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
554bdf7
feat(clickhouse): add optional retention TTL on the snapshot table
levivannoort 96d1962
fix(clickhouse): remove TTL when retention is disabled; make retentio…
levivannoort 8ac5867
fix(clickhouse): tolerate REMOVE TTL on tables without a TTL
levivannoort 1b57aaa
Merge pull request #20 from levivannoort/feat/retention-ttl
loks0n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The exception is suppressed by checking that the message contains
"doesn't have any table TTL expression". This substring is not part of a stable ClickHouse API contract — the wording can vary across ClickHouse versions or distributions. If ClickHouse ever rewords that message, the condition will never match, everyREMOVE TTLon a table without a TTL will surface as an uncaught exception, andsetup()will stop being idempotent when disabling retention. Consider also guarding on the ClickHouse error code (36 /NO_SUCH_DATA_PART) via a dedicated exception type or numeric code check if the client library exposes one, and logging a warning rather than silently swallowing the mismatch.Prompt To Fix With AI