Repository navigation
feat(mail): use smtp and local upload storage - #2
Merged
Merged
Conversation
rschlaefli
marked this pull request as ready for review
June 29, 2026 10:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This Adds
This PR updates the Escapp fork for the DF Cloud rollout:
CLOUDINARY_URLis not set./uploads.How It Works
SMTP_HOST,SMTP_PORT,SMTP_SECURE,SMTP_USERNAME,SMTP_PASSWORD, and optionalSMTP_FROM.UPLOADS_PATH, defaulting topublic/uploads.CLOUDINARY_URLis present, but it is no longer required for upload paths.codex/escapp-local-uploads-keda.Branch Coverage
master478d1ddVerification
Current head:
npx eslint helpers/mailer.js helpers/attachments.js controllers/assets_controller.js controllers/hint_controller.js controllers/escapeRoom_controller.js helpers/utils.js-> passednode -e "require(\"./helpers/mailer\"); require(\"./helpers/attachments\"); console.log(\"modules load\")"-> passedgit diff --check-> passedNot run:
Security / Privacy
SMTP_PASSWORDremains runtime-only.Blocking Before Merge
None for source review.
Follow-Up After Merge
SMTP_PASSWORDandSMTP_FROMare present in Escapp Infisical before deploying.