Skip to content

chore: import vaadin-cdi as a Flow module and run its tests in validation - #25525

Merged
Artur- merged 644 commits into
mainfrom
chore/import-cdi-to-flow
Sep 14, 2026
Merged

chore: import vaadin-cdi as a Flow module and run its tests in validation#25525
Artur- merged 644 commits into
mainfrom
chore/import-cdi-to-flow

Merge branch 'main' into chore/import-cdi-to-flow

478d0ce
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Sep 14, 2026 in 1m 29s

Quality Gate passed

Issues
237 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 177 in vaadin-cdi/src/main/java/com/vaadin/cdi/context/RouteScopedContext.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefix this call to "getContextualStorage" with "super.". 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZSZiOK0aa-KLWGA&open=AaB8XZSZiOK0aa-KLWGA&pullRequest=25525

Check warning on line 267 in vaadin-cdi/src/test/java/com/vaadin/cdi/context/RouteContextualStorageManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZGniOK0aa-KLWDT&open=AaB8XZGniOK0aa-KLWDT&pullRequest=25525

Check warning on line 280 in vaadin-cdi/src/test/java/com/vaadin/cdi/context/RouteContextualStorageManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZGniOK0aa-KLWDS&open=AaB8XZGniOK0aa-KLWDS&pullRequest=25525

Check warning on line 49 in vaadin-cdi/src/main/java/com/vaadin/cdi/context/UIScopedContext.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Document this public method by adding an explicit description. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZSBiOK0aa-KLWFw&open=AaB8XZSBiOK0aa-KLWFw&pullRequest=25525

Check warning on line 85 in vaadin-cdi/src/test/java/com/vaadin/cdi/CdiVaadinServletTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZKhiOK0aa-KLWEF&open=AaB8XZKhiOK0aa-KLWEF&pullRequest=25525

Check warning on line 34 in vaadin-cdi/src/main/java/com/vaadin/cdi/AbstractCdiInstantiator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reorder the modifiers to comply with the Java Language Specification. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZR6iOK0aa-KLWFv&open=AaB8XZR6iOK0aa-KLWFv&pullRequest=25525

Check warning on line 86 in vaadin-cdi/src/main/java/com/vaadin/cdi/CdiVaadinServletService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Document this public constructor by adding an explicit description. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZWciOK0aa-KLWGY&open=AaB8XZWciOK0aa-KLWGY&pullRequest=25525

Check warning on line 63 in vaadin-cdi/src/test/java/com/vaadin/cdi/CdiVaadinServletTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock". 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZKhiOK0aa-KLWD5&open=AaB8XZKhiOK0aa-KLWD5&pullRequest=25525

Check failure on line 40 in vaadin-cdi/src/main/java/com/vaadin/cdi/util/ContextualStorage.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make non-static "beanManager" transient or serializable. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZRAiOK0aa-KLWFq&open=AaB8XZRAiOK0aa-KLWFq&pullRequest=25525

Check warning on line 84 in vaadin-cdi/src/test/java/com/vaadin/cdi/context/RouteContextPseudoTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this mock creation to a local variable. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZE_iOK0aa-KLWDC&open=AaB8XZE_iOK0aa-KLWDC&pullRequest=25525

Check warning on line 368 in vaadin-cdi/src/test/java/com/vaadin/cdi/context/RouteContextualStorageManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZGniOK0aa-KLWDc&open=AaB8XZGniOK0aa-KLWDc&pullRequest=25525

Check warning on line 90 in vaadin-cdi/src/test/java/com/vaadin/cdi/CdiVaadinServletTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZKhiOK0aa-KLWEH&open=AaB8XZKhiOK0aa-KLWEH&pullRequest=25525

Check warning on line 258 in vaadin-cdi/src/test/java/com/vaadin/cdi/CdiInstantiatorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'jakarta.servlet.ServletException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZMRiOK0aa-KLWEU&open=AaB8XZMRiOK0aa-KLWEU&pullRequest=25525

Check warning on line 109 in vaadin-cdi/src/main/java/com/vaadin/cdi/CdiVaadinServletService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter "session". 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZWciOK0aa-KLWGh&open=AaB8XZWciOK0aa-KLWGh&pullRequest=25525

Check warning on line 210 in vaadin-cdi/src/test/java/com/vaadin/cdi/CdiVaadinServletServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "service" which hides the field declared at line 125. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZOSiOK0aa-KLWEl&open=AaB8XZOSiOK0aa-KLWEl&pullRequest=25525

Check warning on line 574 in vaadin-cdi/src/test/java/com/vaadin/cdi/context/RouteContextualStorageManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZGniOK0aa-KLWDp&open=AaB8XZGniOK0aa-KLWDp&pullRequest=25525

Check warning on line 252 in vaadin-cdi/src/main/java/com/vaadin/cdi/util/BeanManagerProvider.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZQ4iOK0aa-KLWFb&open=AaB8XZQ4iOK0aa-KLWFb&pullRequest=25525

Check warning on line 343 in vaadin-cdi/src/main/java/com/vaadin/cdi/util/ClassUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Either log or rethrow this exception. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZQbiOK0aa-KLWE7&open=AaB8XZQbiOK0aa-KLWE7&pullRequest=25525

Check warning on line 147 in vaadin-cdi/src/main/java/com/vaadin/cdi/util/ContextualStorage.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Document the parameter(s): beanKey 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZRAiOK0aa-KLWFn&open=AaB8XZRAiOK0aa-KLWFn&pullRequest=25525

Check failure on line 121 in vaadin-cdi/src/test/java/com/vaadin/cdi/CdiInstantiatorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZMRiOK0aa-KLWER&open=AaB8XZMRiOK0aa-KLWER&pullRequest=25525

Check warning on line 219 in vaadin-cdi/src/test/java/com/vaadin/cdi/CdiInstantiatorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock". 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZMRiOK0aa-KLWET&open=AaB8XZMRiOK0aa-KLWET&pullRequest=25525

Check warning on line 274 in vaadin-cdi/src/test/java/com/vaadin/cdi/CdiInstantiatorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZMRiOK0aa-KLWEV&open=AaB8XZMRiOK0aa-KLWEV&pullRequest=25525

Check failure on line 44 in vaadin-cdi/src/main/java/com/vaadin/cdi/context/AbstractContextualStorageManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make non-static "storageMap" transient or serializable. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZSMiOK0aa-KLWF2&open=AaB8XZSMiOK0aa-KLWF2&pullRequest=25525

Check warning on line 108 in vaadin-cdi/src/main/java/com/vaadin/cdi/context/VaadinSessionScopedContext.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZWEiOK0aa-KLWGM&open=AaB8XZWEiOK0aa-KLWGM&pullRequest=25525

Check warning on line 293 in vaadin-cdi/src/test/java/com/vaadin/cdi/CdiInstantiatorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'jakarta.servlet.ServletException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AaB8XZMRiOK0aa-KLWEX&open=AaB8XZMRiOK0aa-KLWEX&pullRequest=25525
View more details on SonarQubeCloud