chore: bring dependencies and CI up to date (24.7) - #25677
chore: bring dependencies and CI up to date (24.7)#25677totally-not-ai[bot] wants to merge 6 commits into
Conversation
@rollup/plugin-typescript resolves its TypeScript peer dependency freely, so the dev-server bundle now builds against TypeScript 7, where ts.ScriptTarget.ES2015 no longer exists and the vite build fails with "Cannot read properties of undefined (reading 'ES2015')". Pinning the same 5.x range the other branches use keeps the build working.
The branch had not been updated since January, so libraries, build plugins and frontend packages are behind the versions 24.10 ships. Everything stays within its current major, and Spring Boot stays on the 3.4 line the branch was released with.
Builds were only allowed for actors with write access, which fails for bots and outside contributors and left the branch without a way to run CI at all. Pull requests also ran through pull_request_target, which executes the base branch workflow with secrets against the pull request code. Also brings in the frontend dependency update script so the branch can be added to the weekly update workflow.
TestBench 9.6.3 ships a Selenium whose generated CDP package no longer matches the v136 classes this used, and the generated classes only work for the Chrome versions a Selenium release happens to bundle. Building the few Network and Target commands by hand, as 24.10 does, keeps the offline and cache tests working with any Chrome.
jsoup no longer breaks the line before a nested element when pretty printing, and the default dev dependency test states the glob version the frontend manifest now pins.
Type of change
How to test
Verified locally on JDK 17 with the same commands CI runs: full install API changesCompared to
No removals or signature changes. Why the build broke by itself
|
Test Results1 090 files - 106 1 090 suites - 106 1h 2m 42s ⏱️ - 11m 36s For more details on these failures, see this check. Results for commit ed0f38c. ± Comparison against base commit cffb87c. ♻️ This comment has been updated with latest results. |
TestBench 9.5 and later need the license checker 2.x and 3.x APIs, which are a major step from the 1.x this branch ships, so every integration test failed to initialise with NoClassDefFoundError. 9.4.5 is the newest release that still runs against the 1.x checker, and its Selenium only has the single argument CDP connection factory.
1 participant
Related to #25675
build failure · whole build · anyone building or releasing 24.7
The branch has not been touched since January and no longer builds: the
dev-server bundle is compiled with whatever TypeScript npm resolves, and
TypeScript 7 removed the API the Rollup plugin calls. Libraries, build
plugins and frontend packages are months behind as well, so this brings
them to what 24.10 ships without crossing a major, and makes the
validation workflow runnable again.
Risks:
6.4.3, Lit 3.3.3, React 19.3.0, react-router 7.18.3, TypeScript 5.9.3)
and Flow now installs Node v22.23.2 and pnpm 8.15.9 by default.
DevToolsWrapper.close()added inflow-test-util.current patch releases on the lines this branch ships.
they need the TestBench license. CI has to confirm them.
Context. 24.7 is commercially supported again, so the branch has to
build and release. Its validation workflow started every job with a
write-access check that fails for bots and outside contributors, which is
why the breakage went unnoticed, and pull requests ran through
pull_request_target, which executes the base branch workflow withsecrets against the pull request code.
typescriptto^5.9.3invaadin-dev-server, the same fix24.10 got in build(vaadin-dev-server): align TypeScript version (24.10) #24959, which is what makes the build pass again.
Spring Boot 3.4.13, Jackson 2.21.5, jsoup 1.23.1, Guava 33.7.1, slf4j
2.0.17, Jetty 12.0.27, TestBench 9.6.3, Surefire/Failsafe 3.5.3.
cannot corrupt local repository metadata.
scripts/update-frontend-dependencies.sh, which caps every non-mainbranch at minor releases, and raised the default Node and pnpm versions.
DevToolsWrapperwithhand-built
NetworkandTargetcommands, as 24.10 does: the generatedones only work for the Chrome versions a Selenium release bundles.
archived
stCarolas/setup-maven, moved pull requests topull_request, guarded the TestBench license check for fork pullrequests, pinned every action to a commit, and listed the branches that
are maintained today.
ElementTestexpectations to jsoup's current prettyprinting and the
NodeUpdaterTestglob version to the manifest.