chore: bring dependencies and CI up to date (24.4) - #25678
chore: bring dependencies and CI up to date (24.4)#25678totally-not-ai[bot] wants to merge 8 commits into
Conversation
@rollup/plugin-typescript resolves its TypeScript peer dependency freely, so the dev-server bundle now builds against TypeScript 7, where ts.ScriptTarget.ES2015 no longer exists and the vite build fails with "Cannot read properties of undefined (reading 'ES2015')". Pinning the same 5.x range the other branches use keeps the build working.
The branch had not been updated since January, so libraries, build plugins and frontend packages are behind the versions 24.10 ships. Everything stays within its current major, which leaves Spring Boot on 3.2.12, the last release of the line the branch shipped with.
Builds were only allowed for actors with write access, which fails for bots and outside contributors and left the branch without a way to run CI at all. The jobs also ran on ubuntu-22.04 and installed Chrome from a floating action, where the newer branches use the browser the runner image ships. Also brings in the frontend dependency update script so the branch can be added to the weekly update workflow.
TestBench 9.6.3 ships a Selenium whose generated CDP package no longer matches the v128 classes this used, and the generated classes only work for the Chrome versions a Selenium release happens to bundle. Building the few Network and Target commands by hand, as 24.10 does, keeps the offline and cache tests working with any Chrome, and lets the PWA test drop its pinned selenium-devtools-v123 dependency.
The default dev dependency tests state the Polymer and glob versions the frontend manifest pins.
Type of change
How to test
Verified locally on JDK 17 with the same commands CI runs: full install API changesCompared to
No removals or signature changes. Why the build broke by itself
|
Test Results 585 files - 535 585 suites - 535 11m 25s ⏱️ - 55m 10s For more details on these errors, see this check. Results for commit dbf9eff. ± Comparison against base commit 1cd39cc. |
TestBench 9.5 and later need the license checker 2.x and 3.x APIs, which are a major step from the 1.x this branch ships, so the integration tests fail to initialise. 9.4.5 is the newest release that still runs against the 1.x checker, and it needs 1.13.5 rather than 1.12.14.
The Selenium that TestBench 9.4.5 brings has no overload taking a client configuration.
The annotations came in transitively through TestBench 9.3, which the 9.4 line no longer does, so the tests using @NotThreadSafe stopped compiling. 24.7 and 24.10 declare the dependency for the same reason.
1 participant
Related to #25675
build failure · whole build · anyone building or releasing 24.4
The branch has not been touched since January and no longer builds: the
dev-server bundle is compiled with whatever TypeScript npm resolves, and
TypeScript 7 removed the API the Rollup plugin calls. Libraries, build
plugins and frontend packages are further behind than on any other
maintained branch, so this brings them as close to 24.10 as possible
without crossing a major, and makes the validation workflow runnable
again.
Risks:
5.4.21, Lit 3.3.3, Polymer 3.5.2, react-router-dom 6.30.6, TypeScript
5.9.3) and Flow now installs Node v20.20.2 and pnpm 8.15.9 by default.
DevToolsWrapper.close()added inflow-test-util.to their current patch releases. Spring Boot stays on 3.2.12, the last
release of the line this branch ships with.
they need the TestBench license. CI has to confirm them.
Context. 24.4 is commercially supported again, so the branch has to
build and release. Its validation workflow started every job with a
write-access check that fails for bots and outside contributors, which is
why the breakage went unnoticed, and the jobs still ran on ubuntu-22.04
with Chrome installed from a floating action tag.
typescriptto^5.9.3invaadin-dev-server, the same fix24.10 got in build(vaadin-dev-server): align TypeScript version (24.10) #24959, which is what makes the build pass again.
Jackson 2.21.5, jsoup 1.23.1, Guava 33.7.1, slf4j 2.0.17, Hibernate
Validator 8.0.2, Jetty 12.0.27, TestBench 9.6.3, Surefire/Failsafe
3.5.3, Clean 3.4.1, Build Helper 3.6.0, Maven API 3.9.9.
cannot corrupt local repository metadata.
scripts/update-frontend-dependencies.sh, which caps every non-mainbranch at minor releases, and raised the default Node and pnpm versions.
DevToolsWrapperwithhand-built
NetworkandTargetcommands, as 24.10 does, which alsolets the PWA test drop its pinned
selenium-devtools-v123dependency.archived
stCarolas/setup-maven, moved the jobs to ubuntu-24.04 with thebrowser the runner image ships, guarded the TestBench license check for
fork pull requests, pinned every action to a commit, and listed the
branches that are maintained today.
NodeUpdaterTestPolymer and glob expectations to theversions the frontend manifest now pins.
Left out on purpose, because they cross a major: Atmosphere client 3.1.3
to 4.0.1, bnd 6.4.0 to 7.1.0, glob to 12, and Vite to 7.