Skip to content

fix: bound resync detection state kept in the session - #434

Closed
caalador wants to merge 1 commit into
5.0from
fix/resync-session-attributes
Closed

caalador wants to merge 1 commit into
5.0from
fix/resync-session-attributes

Conversation

@caalador

@caalador caalador commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Keep the last clientId of all UIs
in one session attribute, capped at
32 UIs with the oldest dropped first,
instead of one attribute per UI id.
UI ids that are not numeric are no longer stored.

Related: #430

@heruan

heruan commented Oct 5, 2026

Copy link
Copy Markdown
Member

Heads up: #415 (approved) removes the resync detection filters and the session state this PR bounds, so this change will not be needed once it lands. Maybe keep this on hold until #415 is merged.

@Artur-

Artur- commented Oct 5, 2026

Copy link
Copy Markdown
Member

Can #415 be backported, i.e. are the events in Flow 25.3?

@caalador

caalador commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator Author

The events are not in 25.3 as far as I know so this PR is mainly targeted at 5.0 that doesn't get the events.

@heruan

heruan commented Oct 5, 2026

Copy link
Copy Markdown
Member

Makes sense, thanks. Then this should target 5.0 and build on #447 instead of main. One thing to check there: all UIs now share one map that each request copies and writes back. If two tabs post at the same time and the filters lock different objects (for example a new HttpSession wrapper per request), one write can undo the other and a resend goes uncounted.

@caalador
caalador changed the base branch from main to 5.0 October 6, 2026 03:42
Keep the last clientId of all UIs
in one session attribute, capped at
32 UIs with the oldest dropped first,
instead of one attribute per UI id.
UI ids that are not numeric are no longer stored.

Related: #430
@caalador
caalador force-pushed the fix/resync-session-attributes branch from 3d4501f to c620294 Compare October 6, 2026 03:49
@caalador

caalador commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

Rebased on 5.0 and the shared map is fixed so that two tabs posting at the same time no longer undo each other's stored clientId.

@caalador

caalador commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator Author

Closing PR as #449 changes make this not needed anymore.

@caalador caalador closed this Oct 7, 2026
@caalador
caalador deleted the fix/resync-session-attributes branch October 7, 2026 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants