refactor: skip already indexed artifacts in aggregate Jandex indexes - #9518
Merged
Merged
Conversation
vaadin-jandex and vaadin-core-jandex now only index classes from dependencies that do not ship their own META-INF/jandex.idx, avoiding duplicate entries once artifacts (e.g. Flow modules) provide per-artifact indexes. Dependency unpacking is done by scripts/jandex/UnpackNonIndexedJars.java, which copies the classes into a dedicated directory (emptied on each run, so classes from artifacts that gained an index are not kept) and logs which artifacts are still covered by the aggregate index. It warns when the classpath contains no Vaadin jars. A --verify mode fails if any Vaadin jar lacks an index, to be kept as a check once the aggregate modules are removed. The smoke tests now verify that the aggregate index does not overlap with per-artifact indexes, and that expected classes are indexed by either of them. Jandex plugin and library are bumped to 3.6.0.
Contributor
Author
|
After all Vaadin artifacts gets updated to have their own Jandex index, we can remove the platform aggregated Jandex modules (better first deprecate and provide empty ones). |
Contributor
Author
|
Here's what will be reported after the Flow PR gets merged |
Contributor
Dependencies Report
|
Contributor
Author
|
This change can be merged before the Flow PR gets in, as it will not break the existing functionality. |
Artur-
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vaadin-jandex and vaadin-core-jandex now only index classes from dependencies that do not ship their own META-INF/jandex.idx, avoiding duplicate entries once artifacts (e.g. Flow modules) provide per-artifact indexes.
Dependency unpacking is done by scripts/jandex/UnpackNonIndexedJars.java, which copies the classes into a dedicated directory (emptied on each run, so classes from artifacts that gained an index are not kept) and logs which artifacts are still covered by the aggregate index. It warns when the classpath contains no Vaadin jars. A --verify mode fails if any Vaadin jar lacks an index, to be kept as a check once the aggregate modules are removed.
The smoke tests now verify that the aggregate index does not overlap with per-artifact indexes, and that expected classes are indexed by either of them. Jandex plugin and library are bumped to 3.6.0.
Related to vaadin/flow#25899