test: add Lumo visual tests for field and group field mixins - #12736
Open
vursen wants to merge 6 commits into
Open
test: add Lumo visual tests for field and group field mixins#12736vursen wants to merge 6 commits into
vursen wants to merge 6 commits into
Conversation
The Lumo field mixins are shared by many components. Mock elements let the tests cover them once, without the styles of any single component. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vaadin-review-bot
left a comment
vaadin-review-bot
left a comment
There was a problem hiding this comment.
Reviewed the changes — left 3 comments.
| Finding | |
|---|---|
| 🧪 | Mock fields lack DirMixin, so the RTL tests never exercise Lumo's [dir='rtl'] rules |
| 🧪 | The wrapped test sits under the vertical theme, where wrapping cannot happen |
| 📐 | No not-animated styles, while the Lumo error message transitions max-height over 0.4s |
vursen
added this pull request to stack #12737
September 11, 2026 12:29
Without it the mock hosts never get the `dir` attribute, so the Lumo `:host([dir='rtl'])` rules for the required indicator and the error message were not covered by the RTL tests. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Lumo lays the group out in a wrapping row by default and switches to a column for the `vertical` theme, so the width limit only wraps items in the default layout. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The Lumo error message transitions `max-height`, so the screenshot depends on when it is taken. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mock-fieldandmock-group-fieldfixtures. They use the shared Lumo field mixins without the styles of a single component.Type of change
🤖 Generated with Claude Code