fix: restore filter to input on Escape in multi-select-combo-box - #12738
Open
web-padawan wants to merge 1 commit into
Open
fix: restore filter to input on Escape in multi-select-combo-box#12738web-padawan wants to merge 1 commit into
web-padawan wants to merge 1 commit into
Conversation
Pressing Escape while an item is highlighted reverts the input through `_revertInputValue()`. The base implementation assigns `value`, which multi-select-combo-box declares private and never assigns, so the input was emptied while `filter` stayed set and the dropdown stayed filtered. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
vaadin-review-bot
left a comment
vaadin-review-bot
left a comment
There was a problem hiding this comment.
✅ Nothing to flag — the changes look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pressing Escape while an item is highlighted reverts the input through
_revertInputValue(). The base implementation assignsvalue, which suits a single value field. Multi-select-combo-box keeps its selection inselectedItems, declaresvalueas private and never assigns it, so the assignment always wrote an empty string. The input was cleared whilefilterstayed set and the overlay stayed open, leaving the list filtered against text the user could no longer see. Combo-box already restores the filter in its own override, which is also what the comment in the base handler describes._revertInputValue()override that restores the input to the current filterkeepFilterThe nearest existing test presses Escape twice and only asserts afterwards, so the first press clearing the input was hidden by the second press closing the overlay and clearing the filter for real.
Type of change
How to test
dev/multi-select-combo-box.htmlliin the fieldliagain and the dropdown stays open with the filtered items🤖 Generated with Claude Code