test: add overlay opening tests for multi-select-combo-box - #12744
test: add overlay opening tests for multi-select-combo-box#12744web-padawan wants to merge 2 commits into
Conversation
Mirrors the files that combo-box and time-picker already have. The component had no coverage for opening by a label or input click, the arrow keys, open(), autoOpenDisabled, or an empty items array. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vaadin-review-bot
left a comment
vaadin-review-bot
left a comment
There was a problem hiding this comment.
Reviewed the changes — left 1 comment.
| Finding | |
|---|---|
| 🧪 | The opening disallowed block drops the helper and error message click cases that both sibling files have, hiding a real behavior difference |
| }); | ||
| }); | ||
|
|
||
| describe('opening disallowed', () => { |
There was a problem hiding this comment.
🧪 The opening disallowed block drops the helper and error message click cases that both sibling files have, hiding a real behavior difference
Both sibling files assert that a click on the helper text or the error message does not open the dropdown. Those two tests are missing here, and the PR description does not mention the omission.
The reason they would not pass is worth a look: combo-box and time-picker both override _onHostClick to only open when the click path includes the label or the input field. Multi-select-combo-box has no such override, so a host click anywhere — helper text, error message — reaches the base implementation and opens the dropdown.
Either add the tests and fix the override, or state in the description that the divergence is intentional.
overlay-opening.test.js:125 · tests
Opening on a chip click holds only because chips are slotted into the input field element, which `composedPath()` sees but `contains()` does not. The remove button relies on its own `stopPropagation()` instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ecd1055 to
7e5b89c
Compare
|
2 participants
Description
Combo-box and time-picker each have an
overlay-opening.test.js. Multi-select-combo-box had no equivalent, and no coverage for several ways the dropdown opens.overlay-opening.test.jsfollowing the structure and test names of the two sibling filesopen()autoOpenDisabledvariants of those, and that the toggle button still opensdisabledis set, and whenitemsorfilteredItemsis empty or nullRead-only is left out because multi-select-combo-box opens while read-only to show the selected items, and
readonly.test.jsalready covers that.Type of change
🤖 Generated with Claude Code