Port batch log streaming onto streamOnce and follow#15
Merged
Conversation
This branch was cut from a stale local master, before #11 replaced streamRequest with streamOnce plus a reconnecting follow helper. The squash merge of #14 produced no textual conflict -- the removed symbol and the new call site are in different parts of the file -- so master built green in the branch and broken on trunk. Batch log streaming now uses the same path service logs do. A followed stream reconnects and resumes at an exact byte offset. It always starts at the beginning of the log rather than anchoring to the end: an execution's output is finite and usually short, so there is nothing to gain from skipping the start and a real chance of missing all of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a broken master. I cut #14 from a stale local master, before #11 replaced
streamRequestwithstreamOnceplus a reconnectingfollowhelper. The squash merge produced no textual conflict — the removed symbol and my new call site sit in different parts of the file — so it built green on the branch and broken on trunk.Batch log streaming now uses the same path service logs do, including reconnect-and-resume at an exact byte offset. It always starts at the beginning of the log rather than anchoring to the end: an execution's output is finite and usually short, so skipping the start risks missing all of it for nothing.
Verified against the live platform after the fix.