Repository navigation
Preserve Nuplane observer failure diagnostics - #165
Conversation
|
Source verification passed at implementation commit
Exact commands (all through the shared dotnet build-slot wrapper): dotnet test tests/CShells.Tests/CShells.Tests.csproj -c Release --filter FullyQualifiedName~Nuplane --no-restore
dotnet test tests/CShells.Tests/CShells.Tests.csproj -c Release --no-restore --logger 'trx;LogFileName=full-library.trx' --results-directory <root-qa/full-library-results>
dotnet build src/CShells.Nuplane/CShells.Nuplane.csproj -c Release -f net8.0
dotnet build src/CShells.Nuplane/CShells.Nuplane.csproj -c Release -f net9.0
dotnet build src/CShells.Nuplane/CShells.Nuplane.csproj -c Release -f net10.0
dotnet build src/CShells.Nuplane/CShells.Nuplane.csproj -c Release -f net10.0 --no-restoreMutation/restoration used Copilot and Greptile are waived by the human; neither was requested. Normal PR CI, resulting-main package publication, ten actual-public package archive audit and PackageReference-only .NET8/9/10 diagnostics qualification remain pending. Issue164 stays open until actual-public qualification; Foundation2314 remains blocked on164. No stable release or Foundation pin change is claimed. |
|
Final pre-merge gate passed for Normal squash merge follows with an exact-head guard, without admin bypass. Resulting-main CI/package publication and actual-public ten-package/runtime qualification remain required; #164 stays open pending that acceptance. |
Nuplane catches observer exceptions and emits a Warning containing only the exception message. When the CShells adapter fails to refresh or reload, operators therefore lose its exception diagnostics. The adapter now records one Error with the original exception, reconciliation correlation and operation name, then rethrows so Nuplane keeps its existing warning, continuation and retry behavior.
The logger is optional and supplied through the existing coordinator factory. Requested cancellation, fatal exceptions, pre-admission validation, build-only refresh and returned per-shell errors retain their existing behavior. The Nuplane runtime dependency is test-only; the adapter adds only the direct logging abstraction dependency.
Refs #164 and #142. Issue164 remains open for the owner-published preview and actual-public consumer qualification after merge.
Validation:
edbf58283b562e9288fa5986683c0eef4b533dc8: no material findings. Follow-up task marks only reflect those retained checks. Diff whitespace check passed.The human waived Copilot and Greptile; neither is requested. PR CI and resulting-main/public-package qualification are still required. No stable package promotion or downstream pin change is included.