Repository navigation
Fix memory leaks and a mismatched new / delete[] - #56
Merged
Merged
Conversation
Found with valgrind --leak-check=full on ACVD, ACVDQ, ACVDP and ACVDQP; all four now report 0 bytes definitely lost. - vtkQEMetricForClustering never freed Items. It is now initialised to 0 and deleted in the destructor, as vtkIsotropicMetricForClustering does. - vtkSinglePolynomialMeasure allocated SecondMember[i] with new double and freed it with delete []. Its matrices and Quadric are now contiguous std::vector / array storage with row pointers for SolveLeastSquares. - vtkThreadedClustering::ComputeEdgesLayout never freed its EdgesLayout array; it is now a std::vector moved into EdgesProcess. - vtkSurface::WriteToFile never deleted its writer.
Contributor
Author
|
This is just the leaks. Could next fix the missing determinism. I did this while also switching to a more efficient threading backend. Let me know if you want the determinism next. Then we could change the filter to properly do in-place operations, the pipeline have support for that. Finally, if you want, SMPTools and modern typed interface avoids a lot of virtual calls, which translates to performance. |
Owner
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found with valgrind --leak-check=full on ACVD, ACVDQ, ACVDP and ACVDQP; all four now report 0 bytes definitely lost.