Preserve original Unicode text on request - #35
Draft
vanderlee wants to merge 8 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Sentence::SPLIT_PRESERVEas a backward-compatible opt-in flag.SPLIT_TRIM.Why
The splitter currently normalizes curly quotes and apostrophes before returning sentences. That makes returned text differ from the input and prevents callers from locating sentence substrings in the original source.
The default behavior remains unchanged. Preservation is explicit because existing callers may depend on normalized output.
Validation
The patch workflow passed the Composer test suite on PHP 8.4 and then again on PHP 5.4 with explicit UTF-8 offsets. The branch is stacked on PR #30, whose PHP 5.4–8.5 matrix is green.
Closes #24.