Skip to content

fix(desktop): keep hosted-search citations on the source origin - #579

Merged
vastsa merged 1 commit into
mainfrom
fix/hosted-search-citation-safety
Sep 18, 2026
Merged

vastsa merged 1 commit into
mainfrom
fix/hosted-search-citation-safety

Conversation

@vastsa

@vastsa vastsa commented Sep 18, 2026

Copy link
Copy Markdown
Owner

摘要

跟进 #570:引用 favicon 不再走第三方,正文链接只在路径匹配或 #cite= 时变成徽章。

行为

  • favicon 只请求来源 origin 的 /favicon.ico,不再把 hostname 发给 a.favicon.im
  • sourcesForHref 去掉 host-only 回退;同主机不同路径保持普通链接
  • #cite=N 与 host+path 匹配仍替换为引用徽章

测试

  • apps/desktop/test/hosted-search-ui.test.mjs

Do not send citation hostnames to a third-party favicon service.
Replace markdown links with citation badges only on #cite= or host+path match.
Copilot AI lite review requested due to automatic review settings September 18, 2026 08:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vastsa
vastsa merged commit f36d956 into main Sep 18, 2026
1 of 4 checks passed
@vastsa
vastsa deleted the fix/hosted-search-citation-safety branch September 21, 2026 11:16

This branch was successfully deployed

1 active deployment
Preview — 25b520c1 Deployed Sep 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants