Skip to content

fix(desktop): 揭示工作区浏览器时不记入导航栈 - #580

Merged
vastsa merged 1 commit into
mainfrom
fix/open-http-url-nav-record
Sep 18, 2026
Merged

vastsa merged 1 commit into
mainfrom
fix/open-http-url-nav-record

Conversation

@vastsa

@vastsa vastsa commented Sep 18, 2026

Copy link
Copy Markdown
Owner

Follow-up to #566 / #578.

问题

插件/设置页点 HTTP 链接若目标是工作区浏览器,会 setPage(\"chat\") 并默认 record: true,把一次「揭开 dock」写进导航栈。Back 会回到插件/设置页,但前进栈被截断,这次打开不像一次真正的页面跳转。

改动

  • 抽出 planHttpUrlOpen,工作区目标从遮罩页回到对话时用 setPage(\"chat\", { record: false })。
  • 无会话或设置为系统浏览器时仍走 browserOpenExternal。
  • 单测改为真正执行 opener(不再只扫源码),覆盖 trim、非 HTTP、无会话回退、以及不记 hop。

验证

  • apps/desktop/test/open-http-url.test.mjs 12/12
  • apps/desktop/test/tool-row-file-refs.test.mjs 8/8

…rowser

Opening a plugin/settings HTTP link already returns to chat so the dock is
visible. That switch is not a page navigation — keep Back on the covering
entry and fall back to the OS browser when no session can show the panel.
Copilot AI lite review requested due to automatic review settings September 18, 2026 08:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vastsa
vastsa merged commit aa02e8e into main Sep 18, 2026
1 of 4 checks passed
@vastsa
vastsa deleted the fix/open-http-url-nav-record branch September 21, 2026 11:16

This branch was successfully deployed

1 active deployment
Preview — 20fc4541 Deployed Sep 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants