Skip to content

feat(tray): land PR #402 session shortcuts onto current main - #636

Merged
vastsa merged 7 commits into
mainfrom
merge/pr-402
Sep 19, 2026
Merged

vastsa merged 7 commits into
mainfrom
merge/pr-402

Conversation

@vastsa

@vastsa vastsa commented Sep 19, 2026

Copy link
Copy Markdown
Owner

Summary

Lands PR #402 (issue #293) onto current main.

The original PR was sound but could not merge (CONFLICTING). This branch:

  • preserves the contributor commits (feat(tray): add bounded session shortcuts and the shared row-budget follow-up)
  • resolves conflicts with remote-host IPC routing, app-shell imports, and the Chinese E2E matrix
  • adds a small landing fix so a malformed agent/host payload cannot throw inside sendToRenderer

Validation

  • pnpm build:js, desktop/shared/i18n typecheck
  • architecture gate (index.ts 1499/1500)
  • biome + desktop style tokens
  • docs locale/docs check (78 pairs)
  • shared 810, i18n 25, desktop 2343 / 2343

Native tray E2E (E2E-TRAY-bounded-session-navigation) was not run; unit/build results do not prove OS menu behavior.

Closes #402
Closes #293

zszz3 and others added 7 commits September 15, 2026 16:29
Every non-empty group still keeps its own three-row share, but the share
smaller groups leave unused now goes to the groups that still overflow, in
Running -> Unread -> Pinned order, up to nine rows in total. Seven running
sessions with no unread or pinned show all seven instead of three. Overflow
is measured against the share a group actually received, so View more no
longer appears when every session is already listed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Keep remote-host IPC routing while refreshing the tray after local session
and inbox mutations. Preserve the current app-shell layout imports and the
tray preference mirror. Keep the existing Chinese E2E matrix row and add
the tray navigation scenario.
Guard tray event observation so a bad payload cannot throw inside
sendToRenderer. Cover unread grouping, archive exclusion, preference
validation, and title truncation.
Copilot AI lite review requested due to automatic review settings September 19, 2026 07:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vastsa
vastsa merged commit 2436ad5 into main Sep 19, 2026
3 of 4 checks passed
@vastsa
vastsa deleted the merge/pr-402 branch September 19, 2026 07:34
MakkaPakka12138 pushed a commit to MakkaPakka12138/PI-Desktop that referenced this pull request Sep 19, 2026
vastsa#636 subscribed to mouse-enter so a failed Host read could retry on hover.
On macOS that event replaces NSStatusItem with a custom view, which hides
the extra and stops the attached menu. Gate hover/right-click retry to
Windows/Linux; macOS still refreshes from session and inbox events.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Show running, unread, and pinned sessions in the tray menu (3 per group)

3 participants