Turbopack: Add support for additionalRoots to deployment adapters - #99015
Merged
Merged
Conversation
Contributor
Tests PassedCommit: 801de1d |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
bgw
force-pushed
the
bgw/additional-roots-deployment-adapters
branch
from
September 23, 2026 20:10
3e6484d to
37aae5a
Compare
bgw
marked this pull request as ready for review
September 23, 2026 20:10
|
|
||
| ## Examples | ||
|
|
||
| ### Root directory |
Contributor
There was a problem hiding this comment.
discussed in person
these two sections are maybe not 'examples' so much as 'descriptions', could go in a different section and/or their own pages
Member
Author
There was a problem hiding this comment.
Will do this in a follow-up.
bgw
changed the title
Contributor
There was a problem hiding this comment.
move this so it is a sibling of code under test
| import { createAdapterSyntheticSymlinkDirectory } from '../../../packages/next/src/build/adapter/synthetic-symlinks' | ||
|
|
||
| describe('adapter synthetic symlinks', () => { | ||
| describe('mapNftFileEntries', () => { |
Contributor
There was a problem hiding this comment.
should this be next to the other tests for mapNftFileEntries
lukesandberg
approved these changes
Sep 23, 2026
bgw
enabled auto-merge (squash)
September 23, 2026 23:32
bgw
disabled the stack merge
September 23, 2026 23:47
bgw
added this pull request to stack #99131
September 23, 2026 23:47
bgw
force-pushed
the
bgw/additional-roots-deployment-adapters
branch
from
September 23, 2026 23:49
5fa81fe to
801de1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #98003 so that this works with
vc deploy(or anything else using the adapters API, this isn't a breaking change).Creates "synthetic" symlinks when it needs to rewrite a symlink target (for cross-root links).
Potential follow-up: We can potentially extend the adapter API to let us pass the full symlink information to adapters that support it, so that we don't have to create a bunch of synthetic symlink files on disk.