Repository navigation
ci: run make build on PRs, cloud build only on main - #33
Merged
Merged
Conversation
The cloud builder clones this repo and checks out the PR SHA, so it cannot build a fork PR's commit. Running `make build` on GitHub runners under `pull_request` tests the same scripts with no secrets, which retires the `safe to test` gate and its `pull_request_target` checkout. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
viam-ci-workflows
Bot
added
the
safe to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build Test cannot pass on a fork PR. The cloud builder clones the
urlinmeta.jsonand checks out the PR SHA, which a clone of this repo lacks, so #32 fails withreference is not a treeon every platform, as has every fork PR since #21 addedref.PRs run
make buildinstead, the samesetup.shandbuild.shthe builder runs: linux inside the builder's owncloud-build-base:*-focalimages, darwin on macos-15 with the builder's Python 3.13. These jobs run underpull_requestwith no secrets, so thesafe to testlabel,pull_request_targetand the label manager go away; the repo still makes a maintainer approve runs from external contributors. The cloud build runs only on pushes to main, so failures specific to the builder (brew deps, caches, model detection, thebuildblock inmeta.json) appear after merge.Darwin cloud builds keep failing until viam-build/circle-build#49 lands (the cache bug behind #31).
skip-updatenever took effect (viamrobotics/build-action#24), so labeled PRs ranviam module updatewith their ownmeta.json.build-action@v1points at v1.6; the pin moves it to v1.7.4.🤖 Generated with Claude Code