Memory leak fix - #945
Merged
Merged
Conversation
…E-get-geos-from-kinematics
…E-get-geos-from-kinematics
…iamrobotics/acdc into SCOPE-get-geos-from-kinematics
🦋 Changeset detectedLatest commit: 67b2929 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Micheal Parks (micheal-parks)
requested review from
Devin T. Currie (DTCurrie) and
Matthew MacFarquhar (mattmacf98)
August 14, 2026 17:04
Contributor
|
…into memory-leak-fix
Devin T. Currie (DTCurrie)
approved these changes
Aug 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a memory leak discovered by Dan, but can be reproduced by re-rendering any geometry coming from a
.plyor.stlmany times.The fix is twofold: first destroy and recreate
<T>components that have new incoming geometries. This fix isn't sufficient alone and causes a major performance regression since T component setup and destroy is nontrivial. The second part is to do equality tests for mesh geometries just like we do with primitives, and only update entities if the geometry has changed.